Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of deprecated astropy.tests.pytest_plugins from conftest.py L9 #660

Closed
kakirastern opened this issue Feb 15, 2019 · 7 comments
Closed
Milestone

Comments

@kakirastern
Copy link

Hi,

My recent commits in PR #659 passed almost all the tests that should be have been passed except for the Travis CI. Upon closer inspection of the code, I found out that there is some problem with the following file:

https://github.com/astropy/ccdproc/blob/master/ccdproc/conftest.py

The error thrown in the output of the Travis CI is as follows:

ImportError while loading conftest '/tmp/ccdproc-test-r9jki1ep/lib/python3.6/site-packages/ccdproc/conftest.py'.
ccdproc/conftest.py:9: in <module>
    from astropy.tests.pytest_plugins import *
E   ModuleNotFoundError: No module named 'astropy.tests.pytest_plugins'
The command "$MAIN_CMD $SETUP_CMD" exited with 4.

(https://travis-ci.org/astropy/ccdproc/jobs/493581671)

Is there anything I can do about the situation?

I think this Issue is related to astropy/astropy#7782...

@mwcraig mwcraig added this to the 2.0 milestone Mar 7, 2019
@mwcraig
Copy link
Member

mwcraig commented Mar 7, 2019

Yeah, that dates back to when the pytest plugins were part of astropy itself as opposed to being in a separate package like they are now. Will devote some time on Friday to ccdproc, which really needs some TLC...

@kakirastern
Copy link
Author

Yeah, and I should work on restructuring the docs soon to help with improving the flow, now that I know more about how best to fix/reorganize its contents and where to find info to help me with the task.

@mwcraig
Copy link
Member

mwcraig commented Mar 8, 2019

Even a suggested outline for updated documentation would be very helpful....a full re-write is a pretty heavy lift!

@kakirastern
Copy link
Author

Yup, you are right... Will go through the docs again and come up with some suggestions

@mwcraig
Copy link
Member

mwcraig commented Mar 8, 2019

I'm going to fix this one as part of finishing up #650

@kakirastern
Copy link
Author

Okay, sure

@MatteoSerafino
Copy link

Hi everybody,
I'm still trying to figure out how to fix the problem.
I'm new in GitHub, so I do not know exactly how to move.
May you help me?
what should I change??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants