Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unused pair counting function #881

Open
duncandc opened this issue Feb 27, 2018 · 2 comments
Open

unused pair counting function #881

duncandc opened this issue Feb 27, 2018 · 2 comments

Comments

@duncandc
Copy link
Contributor

I don't think marked_cpairs.conditional_pairwise_distances.pyx is used in the package. Any qualms with removing it? @aphearin

@aphearin
Copy link
Contributor

If it's not being used, then it should be deleted, so good catch. So long as the disappearance is clearly marked (make sure the module name and the main function name appear in the commit message and also the PR), we can always search for the code in case we decide we want to put it back in.

@duncandc
Copy link
Contributor Author

Ok, let's do that for now. I will take care of it. It is old code that doesn't really follow the structure of the pair functions we do use.

I am actually coding up a replacement for it in a different branch for a different project. So it won't be forgotten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants