Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate endpoint treatment of bin-free CAM into Cython #891

Open
aphearin opened this issue Mar 12, 2018 · 0 comments
Open

Migrate endpoint treatment of bin-free CAM into Cython #891

aphearin opened this issue Mar 12, 2018 · 0 comments

Comments

@aphearin
Copy link
Contributor

In the bin-free CAM implementation introduced in #888, the first and last nwin elements are treated using the naive pure python algorithm. For typical nwin values of a few hundred, the runtime is only tens of ms, so it was easier to just stick with naive python since the bookkeeping of the indices at the endpoints is tedious. But the runtime is hundreds of ms for nwin>~1000, a sizeable fraction of the total runtime, so the endpoints would be better treated within cython. Brute force unit-testing against the naive python algorithm is already implemented, so all the infrastructure is present to facilitate the improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant