Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percentage (%) operation Not working #31

Open
astush1001 opened this issue Oct 5, 2023 · 9 comments · May be fixed by #34
Open

Percentage (%) operation Not working #31

astush1001 opened this issue Oct 5, 2023 · 9 comments · May be fixed by #34

Comments

@astush1001
Copy link
Owner

No description provided.

@theDevSoham
Copy link

Hey @astush1001 I can work on this issue. Please assign me

@astush1001
Copy link
Owner Author

Okay !

@architadas2005
Copy link

Can you please assign me

@theDevSoham
Copy link

theDevSoham commented Oct 6, 2023

Hey @astush1001 just a question you want the (%) operator to do the modulus function or percentage function? In case of modulus it'll return the remainder of a division. Say 9 % 2 = 1. In case of percentage it'll divide the value by 100 and return it. Say 9% = 0.09. Also checked that for percentage if any number is pressed after % it'll automatically multiply the next number. It'll look like this: 9% x 2.

As of now I've implemented both the operations. It's checking if there's any number after % sign. If so it'll evaluate the modulus function else it'll implement percent function. There's just 2 lines of code change, I'm sending a PR please check out and let me know if any changes need to be done

@theDevSoham theDevSoham linked a pull request Oct 6, 2023 that will close this issue
@theDevSoham
Copy link

Hey @astush1001 any updates on the PR I sent?

@astush1001
Copy link
Owner Author

Hey @theDevSoham ! Sorry for delay.
Actually I checked your modification but Still it doesn't serve the purpose.
I want to calculate percentage by "%" operator
for example : 87%500 should give me 435 i.e. it should calculate the percentage just as in some other calculator.

See if you can do something regarding that.

@theDevSoham
Copy link

@astush1001 gotcha...btw the percentage function is also there. I'll check and update the PR accordingly.

@theDevSoham
Copy link

@astush1001 Pushed the new changes please check

@theDevSoham
Copy link

Hello @astush1001 any updates yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants