-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Percentage (%) operation Not working #31
Comments
Hey @astush1001 I can work on this issue. Please assign me |
Okay ! |
Can you please assign me |
Hey @astush1001 just a question you want the (%) operator to do the modulus function or percentage function? In case of modulus it'll return the remainder of a division. Say 9 % 2 = 1. In case of percentage it'll divide the value by 100 and return it. Say 9% = 0.09. Also checked that for percentage if any number is pressed after % it'll automatically multiply the next number. It'll look like this: 9% x 2. As of now I've implemented both the operations. It's checking if there's any number after % sign. If so it'll evaluate the modulus function else it'll implement percent function. There's just 2 lines of code change, I'm sending a PR please check out and let me know if any changes need to be done |
Hey @astush1001 any updates on the PR I sent? |
Hey @theDevSoham ! Sorry for delay. See if you can do something regarding that. |
@astush1001 gotcha...btw the percentage function is also there. I'll check and update the PR accordingly. |
@astush1001 Pushed the new changes please check |
Hello @astush1001 any updates yet? |
No description provided.
The text was updated successfully, but these errors were encountered: