Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve npm installation by using pacote for package resolu… #1329

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

achaljhawar
Copy link

  • Add pacote dependency for more stable package name resolution
  • Update generator.js to use pacote.manifest() instead of internal arborist symbols
  • Clean up arborist mock and add new pacote mock for testing

These changes improve package name resolution by using a more stable public API from pacote instead of relying on internal arborist symbols. The changes are focused solely on the package resolution logic, without modifying workflows, arborist version, or supported engines.

Related issue(s)
Resolves #1102

Copy link

changeset-bot bot commented Jan 6, 2025

⚠️ No Changeset found

Latest commit: da95013

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

sonarqubecloud bot commented Jan 6, 2025

@ItshMoh
Copy link

ItshMoh commented Jan 7, 2025

hey @derberg can you approve the workflows for testing.

@derberg
Copy link
Member

derberg commented Jan 7, 2025

@ItshMoh done

@ItshMoh
Copy link

ItshMoh commented Jan 8, 2025

Hey @achaljhawar The CI is failing. Some tests that failed are test1 and test2 .

"js-yaml": "^3.13.1",
"levenshtein-edit-distance": "^2.0.5",
"levenshtein-edit-distance": "^2.0.5pacote",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @achaljhawar You have appended pacote in the version. Correct it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve arborist (npm installation) to have no hacks
3 participants