Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple-git/promise import warning #770

Closed
fidgi opened this issue Apr 9, 2022 · 3 comments · Fixed by #775
Closed

simple-git/promise import warning #770

fidgi opened this issue Apr 9, 2022 · 3 comments · Fixed by #775
Labels
bug Something isn't working released

Comments

@fidgi
Copy link

fidgi commented Apr 9, 2022

Describe the bug

While using the generator to generate html doc , a warning from simple-git is raised :

`

simple-git has supported promises / async await since version 2.6.0.
Importing from 'simple-git/promise' has been deprecated and will be
removed by July 2022.

To upgrade, change all 'simple-git/promise' imports to just 'simple-git'

`

How to Reproduce

used generator version : 1.9.1
Just try to generate html doc from an asyncapi.yaml.
npx ag specs/asyncapi.yaml ../node_modules/@asyncapi/html-template -o ./html

Expected behavior

No warning from simple-git

@fidgi fidgi added the bug Something isn't working label Apr 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2022

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@pavlikm
Copy link
Contributor

pavlikm commented Apr 19, 2022

resolved in pull request #775

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants