fix: message can have nested oneOf #333
Conversation
jonaslagoni
requested review from
fmvilas,
derberg,
dalelane,
smoya,
char0n and
asyncapi-bot-eve
as code owners
There was a problem hiding this comment.
Please also remember to update references to new messageObject in all places like https://github.com/asyncapi/spec-json-schemas/blob/8c9f3d72fa20d82fa7045ca5cec8e318d42e8e6e/definitions/3.0.0/channelMessages.json and also in components.
However, in 3.0.0 we don't have such a oneOf messages, we have objects like channel.messages or operation.messages (which is a array of messages) so your change should be done only for 2.x.x :) We have a bug in 3.0.0 schemas.
Those should not be changed in this PR as it has nothing to do with this bug fix 🙂 @magicmatatjahu lets make further changes to the schema files regarding 3.0 after this one, lets's not mix multiple different changes in one. |
|
But yea, components need to change 👍 |
|
@magicmatatjahu never mind, thats actually another bug 🤣 Gonna do that in another PR after this one |
|
Created a separate issue for it: #335 |
|
Kudos, SonarCloud Quality Gate passed!
|
| }, | ||
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "$id": "http://asyncapi.com/definitions/3.0.0/messageObject.json" | ||
| } |
There was a problem hiding this comment.
It is just a notice from GitHub, incase it's relevant for your setup to have newlines at the end of files, in this case I am pretty sure it's not 🙂
|
/rtm |
|
🎉 This PR is included in version 5.0.0-next-major-spec.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 6.0.0-next-major-spec.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This PR fixes the nested
oneOfproblem.Once we agree this is the fix, then I will apply it for the rest of the versions as well.
I think this will be a breaking change 🧐
Solves #332