Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sergio joining as code owner #844

Closed
fmvilas opened this issue Sep 29, 2022 · 5 comments · Fixed by #846
Closed

Sergio joining as code owner #844

fmvilas opened this issue Sep 29, 2022 · 5 comments · Fixed by #846
Labels
released on @next-major-spec released

Comments

@fmvilas
Copy link
Member

fmvilas commented Sep 29, 2022

Hey fellow code owners @derberg, @dalelane, and @asyncapi-bot-eve 😄

I'd like to propose that @smoya joins us as a code owner of the spec and spec-json-schemas repo. I think it's obvious how much he's been contributing lately and he deserves it IMHO. @smoya I hope you also want to accept this (questionable) honor :)

Leave your comments below!
@smoya
Copy link
Member

smoya commented Sep 29, 2022

It would be an honour, totally! ❤️

@dalelane
Copy link
Collaborator

totally agree 100% 👍

@derberg
Copy link
Member

derberg commented Oct 3, 2022

definitely agree, no question about it.
Sergio not only contributed to 2.4 as coordinator but also improved the spec itself a lot with many PRs and participates in review process a lot

This was referenced Oct 4, 2022
Merged
Merged
@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 3.0.0-next-major-spec.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released on @next-major-spec released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add Sergio and Vladimir as code owners fmvilas/spec
5 participants
@fmvilas @smoya @dalelane @derberg @asyncapi-bot