Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vladimir joining as code owner #845

Closed
fmvilas opened this issue Sep 29, 2022 · 7 comments · Fixed by #846
Closed

Vladimir joining as code owner #845

fmvilas opened this issue Sep 29, 2022 · 7 comments · Fixed by #846

Comments

@fmvilas
Copy link
Member

fmvilas commented Sep 29, 2022

Hey fellow code owners @derberg and @dalelane,

I'd like to propose that @char0n joins us as a code owner of the spec and spec-json-schemas repo. I think it's obvious how much he's been contributing lately and he deserves it IMHO. @char0n I hope you also want to accept this (questionable) honor :)

Leave your comments below!

@dalelane
Copy link
Collaborator

absolutely agree - even just looking at the latest contribution, the 2.5.0 release was a great piece of work - but that's on top of loads of other contributions

@derberg
Copy link
Member

derberg commented Oct 3, 2022

definitely agree, no question about it.
Vladimir not only contributed to 2.5 as coordinator but also improved the spec itself a lot with many PRs

@char0n
Copy link
Collaborator

char0n commented Oct 4, 2022

Thank you all for the trust. I do accept and I'll do my best ;]

One question though: Does this automatically also make me the TSC member or being a code owner is unrelated to TSC membership?

@smoya
Copy link
Member

smoya commented Oct 5, 2022

One question though: Does this automatically also make me the TSC member or being a code owner is unrelated to TSC membership?

This is exactly one of the requirements you might fulfill to become TSC member. So, yes 👍

@fmvilas
Copy link
Member Author

fmvilas commented Oct 7, 2022

Yup. The TSC is composed of all the code owners of the organization. There are exceptions like a) someone doesn't want to join, and b) someone belongs to an organization that already surpassed the limit (1/4 of the total members count). Not your case so you're welcome to join the TSC. Would you mind adding yourself to https://github.com/asyncapi/community/blob/master/TSC_MEMBERS.json?

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 3.0.0-next-major-spec.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants