Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Support for Stored Procedure Execution #245

Open
jchrys opened this issue Feb 22, 2024 · 1 comment
Open

[feature] Support for Stored Procedure Execution #245

jchrys opened this issue Feb 22, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jchrys
Copy link
Collaborator

jchrys commented Feb 22, 2024

Is your feature request related to a problem? Please describe.
Currently, there is no support for executing stored procedures in our application, which limits our ability to interact with databases efficiently.

Describe the solution you'd like

  • Implement related specs.

Additional context

@jchrys jchrys added the enhancement New feature or request label Feb 22, 2024
@mirromutth
Copy link
Contributor

mirromutth commented Feb 27, 2024

It is already supported, but MySqlResult emit wrong type, see also my answer.

It should be OutSegment instead of RowSegment, it can be checked by ServerStatus.PS_OUT_PARAMETERS. Unfortunately, if we set Capability.DEPRECATE_EOF on initialization, it seems that ServerStatus.PS_OUT_PARAMETERS is not returned until after the row packet has ended.

So there we should do 3 things:

  • Unset Capability.DEPRECATE_EOF on initialization
  • Check ConnectionContext.getServerStatuses() for each row packet, if ServerStatus.PS_OUT_PARAMETERS is set, the current row packet should be converted to OutSegment instead of RowSegment
  • Add wiki for Stored Procedure

@mirromutth mirromutth self-assigned this Mar 5, 2024
@mirromutth mirromutth added this to the 1.2.0 milestone Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants