Skip to content

Commit

Permalink
Update vuln analysis GHAW to use on.push hook
Browse files Browse the repository at this point in the history
This hook is needed for proper operation of the
`Vulnerability / CodeQL` job so that it can compare
before/after changes against the base branch.

I'm opting to skip limiting either of the on.push or the
on.pull_request hook events to just the base branch, instead
adding a commented directive to imply that I explicitly
made that decision.

To keep *all* jobs from running again on push events in
addition to the pull request events we check the event
type in the job definition and skip running the job
unless it is not a push event.

refs atc0005/todo#56
  • Loading branch information
atc0005 committed Mar 17, 2023
1 parent 10532f6 commit 3e3820a
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions .github/workflows/project-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,21 @@
name: Project Analysis

on:
push:
# branches: [master]

pull_request:
# `synchronized` seems to equate to pushing new commits to a linked branch
# (whether force-pushed or not)
types: [opened, synchronize]

# The branches below must be a subset of the branches above
# branches: [master]

jobs:
lint:
# Only run this job on non-push events (e.g., pull requests)
if: github.event_name != 'push'
name: Lint
uses: atc0005/shared-project-resources/.github/workflows/lint-project-files.yml@master

Expand All @@ -23,9 +31,13 @@ jobs:
uses: atc0005/shared-project-resources/.github/workflows/vulnerability-analysis.yml@master

go_mod_validation:
# Only run this job on non-push events (e.g., pull requests)
if: github.event_name != 'push'
name: Go Module Validation
uses: atc0005/shared-project-resources/.github/workflows/go-mod-validation.yml@master

dependency_updates:
# Only run this job on non-push events (e.g., pull requests)
if: github.event_name != 'push'
name: Dependency Updates
uses: atc0005/shared-project-resources/.github/workflows/dependency-updates.yml@master

0 comments on commit 3e3820a

Please sign in to comment.