Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown formatted URLs not properly detected as Safelinks URLs #516

Open
atc0005 opened this issue Aug 26, 2024 · 1 comment
Open

Markdown formatted URLs not properly detected as Safelinks URLs #516

atc0005 opened this issue Aug 26, 2024 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@atc0005
Copy link
Owner

atc0005 commented Aug 26, 2024

I encountered this today when attempting to use dslg to decode a formatted email.

This pattern decodes properly:

[placeholder](https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fatc0005%2Fsafelinks&data=data_placeholder&sdata=sdata_placeholder&reserved=0)

This pattern does not:

[https://github.com/atc0005/safelinks](https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fatc0005%2Fsafelinks&data=data_placeholder&sdata=sdata_placeholder&reserved=0)

The URL pattern within the URL anchor is enough to throw things off.

@atc0005 atc0005 added the bug Something isn't working label Aug 26, 2024
@atc0005 atc0005 added this to the Future milestone Aug 26, 2024
@atc0005 atc0005 self-assigned this Aug 26, 2024
@atc0005
Copy link
Owner Author

atc0005 commented Oct 16, 2024

Might be worth a look:

Dependencies used by this project are already using it, so it's already in the dependency tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant