Restore on.push hook to Project Analysis workflow to resolve CodeQL scanning warnings
#56
Closed
25 of 26 tasks
Comments
atc0005
added a commit
to atc0005/check-restart
that referenced
this issue
Mar 17, 2023
This hook is needed for proper operation of the `Vulnerability / CodeQL` job so that it can compare before/after changes against the base branch. I'm opting to skip limiting the pull_request hook events to just the base branch, instead adding a commented directive to imply that I explicitly made that decision. refs atc0005/todo#56
atc0005
added a commit
to atc0005/check-restart
that referenced
this issue
Mar 17, 2023
This hook is needed for proper operation of the `Vulnerability / CodeQL` job so that it can compare before/after changes against the base branch. I'm opting to skip limiting either of the on.push or the on.pull_request hook events to just the base branch, instead adding a commented directive to imply that I explicitly made that decision. refs atc0005/todo#56
atc0005
added a commit
to atc0005/check-restart
that referenced
this issue
Mar 17, 2023
This hook is needed for proper operation of the `Vulnerability / CodeQL` job so that it can compare before/after changes against the base branch. I'm opting to skip limiting either of the on.push or the on.pull_request hook events to just the base branch, instead adding a commented directive to imply that I explicitly made that decision. To keep *all* jobs from running again on push events in addition to the pull request events we check the event type in the job definition and skip running the job unless it is not a push event. refs atc0005/todo#56
atc0005
added a commit
to atc0005/check-restart
that referenced
this issue
Mar 17, 2023
This hook is needed for proper operation of the `Vulnerability / CodeQL` job so that it can compare before/after changes against the base branch. I'm opting to skip limiting either of the on.push or the on.pull_request hook events to just the base branch, instead adding a commented directive to imply that I explicitly made that decision. To keep *all* jobs from running again on push events in addition to the pull request events we check the event type in the job definition and skip running the job unless it is not a push event. refs atc0005/todo#56
atc0005
added a commit
to atc0005/bounce
that referenced
this issue
Mar 17, 2023
This hook is needed for proper operation of the `Vulnerability / CodeQL` job so that it can compare before/after changes against the base branch. I'm opting to skip limiting either of the on.push or the on.pull_request hook events to just the base branch, instead adding a commented directive to imply that I explicitly made that decision. To keep *all* jobs from running again on push events in addition to the pull request events we check the event type in the job definition and skip running the job unless it is not a push event. refs atc0005/todo#56
atc0005
added a commit
to atc0005/brick
that referenced
this issue
Mar 17, 2023
This hook is needed for proper operation of the `Vulnerability / CodeQL` job so that it can compare before/after changes against the base branch. I'm opting to skip limiting either of the on.push or the on.pull_request hook events to just the base branch, instead adding a commented directive to imply that I explicitly made that decision. To keep *all* jobs from running again on push events in addition to the pull request events we check the event type in the job definition and skip running the job unless it is not a push event. refs atc0005/todo#56
atc0005
added a commit
to atc0005/bridge
that referenced
this issue
Mar 17, 2023
This hook is needed for proper operation of the `Vulnerability / CodeQL` job so that it can compare before/after changes against the base branch. I'm opting to skip limiting either of the on.push or the on.pull_request hook events to just the base branch, instead adding a commented directive to imply that I explicitly made that decision. To keep *all* jobs from running again on push events in addition to the pull request events we check the event type in the job definition and skip running the job unless it is not a push event. refs atc0005/todo#56
atc0005
added a commit
to atc0005/check-cert
that referenced
this issue
Mar 17, 2023
This hook is needed for proper operation of the `Vulnerability / CodeQL` job so that it can compare before/after changes against the base branch. I'm opting to skip limiting either of the on.push or the on.pull_request hook events to just the base branch, instead adding a commented directive to imply that I explicitly made that decision. To keep *all* jobs from running again on push events in addition to the pull request events we check the event type in the job definition and skip running the job unless it is not a push event. refs atc0005/todo#56
atc0005
added a commit
to atc0005/check-illiad
that referenced
this issue
Mar 17, 2023
This hook is needed for proper operation of the `Vulnerability / CodeQL` job so that it can compare before/after changes against the base branch. I'm opting to skip limiting either of the on.push or the on.pull_request hook events to just the base branch, instead adding a commented directive to imply that I explicitly made that decision. To keep *all* jobs from running again on push events in addition to the pull request events we check the event type in the job definition and skip running the job unless it is not a push event. refs atc0005/todo#56
atc0005
added a commit
to atc0005/check-mail
that referenced
this issue
Mar 17, 2023
This hook is needed for proper operation of the `Vulnerability / CodeQL` job so that it can compare before/after changes against the base branch. I'm opting to skip limiting either of the on.push or the on.pull_request hook events to just the base branch, instead adding a commented directive to imply that I explicitly made that decision. To keep *all* jobs from running again on push events in addition to the pull request events we check the event type in the job definition and skip running the job unless it is not a push event. refs atc0005/todo#56
This was referenced Mar 17, 2023
atc0005
added a commit
to atc0005/check-ntpt
that referenced
this issue
Mar 17, 2023
This hook is needed for proper operation of the `Vulnerability / CodeQL` job so that it can compare before/after changes against the base branch. I'm opting to skip limiting either of the on.push or the on.pull_request hook events to just the base branch, instead adding a commented directive to imply that I explicitly made that decision. To keep *all* jobs from running again on push events in addition to the pull request events we check the event type in the job definition and skip running the job unless it is not a push event. refs atc0005/todo#56
atc0005
added a commit
to atc0005/check-path
that referenced
this issue
Mar 17, 2023
This hook is needed for proper operation of the `Vulnerability / CodeQL` job so that it can compare before/after changes against the base branch. I'm opting to skip limiting either of the on.push or the on.pull_request hook events to just the base branch, instead adding a commented directive to imply that I explicitly made that decision. To keep *all* jobs from running again on push events in addition to the pull request events we check the event type in the job definition and skip running the job unless it is not a push event. refs atc0005/todo#56
This was referenced Mar 17, 2023
atc0005
added a commit
to atc0005/check-process
that referenced
this issue
Mar 17, 2023
This hook is needed for proper operation of the `Vulnerability / CodeQL` job so that it can compare before/after changes against the base branch. I'm opting to skip limiting either of the on.push or the on.pull_request hook events to just the base branch, instead adding a commented directive to imply that I explicitly made that decision. To keep *all* jobs from running again on push events in addition to the pull request events we check the event type in the job definition and skip running the job unless it is not a push event. refs atc0005/todo#56
atc0005
added a commit
to atc0005/check-statuspage
that referenced
this issue
Mar 17, 2023
This hook is needed for proper operation of the `Vulnerability / CodeQL` job so that it can compare before/after changes against the base branch. I'm opting to skip limiting either of the on.push or the on.pull_request hook events to just the base branch, instead adding a commented directive to imply that I explicitly made that decision. To keep *all* jobs from running again on push events in addition to the pull request events we check the event type in the job definition and skip running the job unless it is not a push event. refs atc0005/todo#56
atc0005
added a commit
to atc0005/check-vmware
that referenced
this issue
Mar 17, 2023
This hook is needed for proper operation of the `Vulnerability / CodeQL` job so that it can compare before/after changes against the base branch. I'm opting to skip limiting either of the on.push or the on.pull_request hook events to just the base branch, instead adding a commented directive to imply that I explicitly made that decision. To keep *all* jobs from running again on push events in addition to the pull request events we check the event type in the job definition and skip running the job unless it is not a push event. refs atc0005/todo#56
atc0005
added a commit
to atc0005/check-whois
that referenced
this issue
Mar 17, 2023
This hook is needed for proper operation of the `Vulnerability / CodeQL` job so that it can compare before/after changes against the base branch. I'm opting to skip limiting either of the on.push or the on.pull_request hook events to just the base branch, instead adding a commented directive to imply that I explicitly made that decision. To keep *all* jobs from running again on push events in addition to the pull request events we check the event type in the job definition and skip running the job unless it is not a push event. refs atc0005/todo#56
This was referenced Mar 17, 2023
atc0005
added a commit
to atc0005/dnsc
that referenced
this issue
Mar 17, 2023
This hook is needed for proper operation of the `Vulnerability / CodeQL` job so that it can compare before/after changes against the base branch. I'm opting to skip limiting either of the on.push or the on.pull_request hook events to just the base branch, instead adding a commented directive to imply that I explicitly made that decision. To keep *all* jobs from running again on push events in addition to the pull request events we check the event type in the job definition and skip running the job unless it is not a push event. refs atc0005/todo#56
atc0005
added a commit
to atc0005/elbow
that referenced
this issue
Mar 17, 2023
This hook is needed for proper operation of the `Vulnerability / CodeQL` job so that it can compare before/after changes against the base branch. I'm opting to skip limiting either of the on.push or the on.pull_request hook events to just the base branch, instead adding a commented directive to imply that I explicitly made that decision. To keep *all* jobs from running again on push events in addition to the pull request events we check the event type in the job definition and skip running the job unless it is not a push event. refs atc0005/todo#56
atc0005
added a commit
to atc0005/go-ezproxy
that referenced
this issue
Mar 17, 2023
This hook is needed for proper operation of the `Vulnerability / CodeQL` job so that it can compare before/after changes against the base branch. I'm opting to skip limiting either of the on.push or the on.pull_request hook events to just the base branch, instead adding a commented directive to imply that I explicitly made that decision. To keep *all* jobs from running again on push events in addition to the pull request events we check the event type in the job definition and skip running the job unless it is not a push event. refs atc0005/todo#56
atc0005
added a commit
to atc0005/go-lockss
that referenced
this issue
Mar 17, 2023
This hook is needed for proper operation of the `Vulnerability / CodeQL` job so that it can compare before/after changes against the base branch. I'm opting to skip limiting either of the on.push or the on.pull_request hook events to just the base branch, instead adding a commented directive to imply that I explicitly made that decision. To keep *all* jobs from running again on push events in addition to the pull request events we check the event type in the job definition and skip running the job unless it is not a push event. refs atc0005/todo#56
atc0005
added a commit
to atc0005/mysql2sqlite
that referenced
this issue
Mar 17, 2023
This hook is needed for proper operation of the `Vulnerability / CodeQL` job so that it can compare before/after changes against the base branch. I'm opting to skip limiting either of the on.push or the on.pull_request hook events to just the base branch, instead adding a commented directive to imply that I explicitly made that decision. To keep *all* jobs from running again on push events in addition to the pull request events we check the event type in the job definition and skip running the job unless it is not a push event. refs atc0005/todo#56
atc0005
added a commit
to atc0005/go-nagios
that referenced
this issue
Mar 17, 2023
This hook is needed for proper operation of the `Vulnerability / CodeQL` job so that it can compare before/after changes against the base branch. I'm opting to skip limiting either of the on.push or the on.pull_request hook events to just the base branch, instead adding a commented directive to imply that I explicitly made that decision. To keep *all* jobs from running again on push events in addition to the pull request events we check the event type in the job definition and skip running the job unless it is not a push event. refs atc0005/todo#56
atc0005
added a commit
to atc0005/go-teams-notify
that referenced
this issue
Mar 17, 2023
This hook is needed for proper operation of the `Vulnerability / CodeQL` job so that it can compare before/after changes against the base branch. I'm opting to skip limiting either of the on.push or the on.pull_request hook events to just the base branch, instead adding a commented directive to imply that I explicitly made that decision. To keep *all* jobs from running again on push events in addition to the pull request events we check the event type in the job definition and skip running the job unless it is not a push event. refs atc0005/todo#56
This was referenced Mar 17, 2023
atc0005
added a commit
to atc0005/nagios-debug
that referenced
this issue
Mar 17, 2023
This hook is needed for proper operation of the `Vulnerability / CodeQL` job so that it can compare before/after changes against the base branch. I'm opting to skip limiting either of the on.push or the on.pull_request hook events to just the base branch, instead adding a commented directive to imply that I explicitly made that decision. To keep *all* jobs from running again on push events in addition to the pull request events we check the event type in the job definition and skip running the job unless it is not a push event. refs atc0005/todo#56
atc0005
added a commit
to atc0005/query-meta
that referenced
this issue
Mar 17, 2023
This hook is needed for proper operation of the `Vulnerability / CodeQL` job so that it can compare before/after changes against the base branch. I'm opting to skip limiting either of the on.push or the on.pull_request hook events to just the base branch, instead adding a commented directive to imply that I explicitly made that decision. To keep *all* jobs from running again on push events in addition to the pull request events we check the event type in the job definition and skip running the job unless it is not a push event. refs atc0005/todo#56
atc0005
added a commit
to atc0005/safelinks
that referenced
this issue
Mar 17, 2023
This hook is needed for proper operation of the `Vulnerability / CodeQL` job so that it can compare before/after changes against the base branch. I'm opting to skip limiting either of the on.push or the on.pull_request hook events to just the base branch, instead adding a commented directive to imply that I explicitly made that decision. To keep *all* jobs from running again on push events in addition to the pull request events we check the event type in the job definition and skip running the job unless it is not a push event. refs atc0005/todo#56
atc0005
added a commit
to atc0005/send2teams
that referenced
this issue
Mar 17, 2023
This hook is needed for proper operation of the `Vulnerability / CodeQL` job so that it can compare before/after changes against the base branch. I'm opting to skip limiting either of the on.push or the on.pull_request hook events to just the base branch, instead adding a commented directive to imply that I explicitly made that decision. To keep *all* jobs from running again on push events in addition to the pull request events we check the event type in the job definition and skip running the job unless it is not a push event. refs atc0005/todo#56
atc0005
added a commit
to atc0005/tsm-pass
that referenced
this issue
Mar 17, 2023
This hook is needed for proper operation of the `Vulnerability / CodeQL` job so that it can compare before/after changes against the base branch. I'm opting to skip limiting either of the on.push or the on.pull_request hook events to just the base branch, instead adding a commented directive to imply that I explicitly made that decision. To keep *all* jobs from running again on push events in addition to the pull request events we check the event type in the job definition and skip running the job unless it is not a push event. refs atc0005/todo#56
This was referenced Mar 17, 2023
26 tasks
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Overview
Work performed previously to rework workflow scheduling batched several changes together:
The
remove "on push"change caused issues with theVulnerability / CodeQLjob:refs: https://github.com/atc0005/check-restart/actions/runs/4447435792
I attempted to add the "on push" hook at the shared/importable workflows level, but that does not appear to have resolved the issue. Instead, it looks like I'll need to batch restore the
on.pushhook to all dependent projects so that theVulnerability / CodeQLjob can execute as intended.A side effect of the change is that this will result in the other analysis jobs also running when changes are merged to the primary branch, but the overall CI cost shouldn't be too great. If it is, we can refactor so that the CodeQL workflow job resides within a dedicated workflow file.
TODO
References
The text was updated successfully, but these errors were encountered: