feat(thermostat): add hvac mode #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebglon
force-pushed
the
feat/thermostat/add-hvac_mode
branch
4 times, most recently
from
2997321 to
8279758
Compare
|
@ttherbrink can i have a first review? |
sebglon
force-pushed
the
feat/thermostat/add-hvac_mode
branch
from
8279758 to
e376d3b
Compare
ttherbrink
reviewed
Jan 31, 2025
| this.knxInterface.readKNXGroupAddress(this.settings.ga_hvac_operating_mode) | ||
| .catch((knxerror) => { | ||
| this.log(knxerror); | ||
| throw new Error(this.homey.__('errors.hvac_mode_get_failed')); // TODO add Message translation |
| onCapabilityTargetTemperature(value, opts) { | ||
| this.getMeasuredTemperature(); | ||
| onCapabilityTargetTemperature(value) { | ||
| // this.getMeasuredTemperature(); |
There was a problem hiding this comment.
Is this not needed anymore?
There was a problem hiding this comment.
this seems not required because knx already push value when changed.
There was a problem hiding this comment.
Fair. However I have the feeling it was there for a reason (it was added before i was involved with this repo)
ttherbrink
requested changes
Jan 31, 2025
| onCapabilityTargetTemperature(value, opts) { | ||
| this.getMeasuredTemperature(); | ||
| onCapabilityTargetTemperature(value) { | ||
| // this.getMeasuredTemperature(); |
There was a problem hiding this comment.
Fair. However I have the feeling it was there for a reason (it was added before i was involved with this repo)
sebglon
force-pushed
the
feat/thermostat/add-hvac_mode
branch
from
3de76b6 to
6b0317d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #44