Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path-watcher-spec.js and project-spec.js core renderer tests appear to be failing #117

Closed
DeeDeeG opened this issue Aug 27, 2020 · 1 comment · Fixed by #109
Closed

path-watcher-spec.js and project-spec.js core renderer tests appear to be failing #117

DeeDeeG opened this issue Aug 27, 2020 · 1 comment · Fixed by #109
Labels
bug Something isn't working

Comments

@DeeDeeG
Copy link
Member

DeeDeeG commented Aug 27, 2020

These may be genuine failures, as opposed to mere timeouts. They seem to be consistently failing on multiple branches/ commits of CI.

https://dev.azure.com/atomcommunity/atomcommunity/_build/results?buildId=651&view=logs&j=f28c492c-c33f-521e-c0ca-e4634e70a589&t=aecb01c6-c908-50f5-1041-c70406db810c

https://dev.azure.com/atomcommunity/atomcommunity/_build/results?buildId=652&view=logs&j=f28c492c-c33f-521e-c0ca-e4634e70a589&t=aecb01c6-c908-50f5-1041-c70406db810c&s=d654deb9-056d-50a2-1717-90c08683d50a

https://dev.azure.com/atomcommunity/atomcommunity/_build/results?buildId=648&view=logs&j=550daac1-780e-5da7-0656-6cc5ef4f089f&t=7d84556a-1c63-5ef9-cbb1-73b9f8364163&s=f31e7579-7dd4-5896-0747-ecb037b694c1

Edit: While the tests that fail are rather consistent, the failing tests are still timeouts, so there's a chance this is an issue with how we test, rather than an issue that would adversely affect real-world users of Atom. Nevertheless, having failing CI is not ideal.

@DeeDeeG
Copy link
Member Author

DeeDeeG commented Aug 27, 2020

Seems like this may have started with #44 :/

CI for the PR:
https://dev.azure.com/atomcommunity/atomcommunity/_build/results?buildId=636&view=logs&j=8c681490-898e-516a-de15-050e2aa85dac&t=17534922-7cc9-580b-6cde-17ad953cb370

CI for master immediately after merging the PR:
https://dev.azure.com/atomcommunity/atomcommunity/_build/results?buildId=640&view=logs&j=f28c492c-c33f-521e-c0ca-e4634e70a589&t=aecb01c6-c908-50f5-1041-c70406db810c

It's the same error we're getting now. Either we can find a fix for this, or I suppose we'll need to go back to Visual Studio 2015 or 2017 or an older Windows base image, something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants