Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Images not shown in preview #505

Closed
1 task done
samuela opened this issue Oct 16, 2017 · 12 comments · Fixed by #506
Closed
1 task done

Images not shown in preview #505

samuela opened this issue Oct 16, 2017 · 12 comments · Fixed by #506

Comments

@samuela
Copy link

samuela commented Oct 16, 2017

Prerequisites

Description

Images are not being displayed in markdown preview.

Steps to Reproduce

  1. Put an image in eg. blah/relative_dir/image.jpg and save this markdown file in blah/
[//]: # (Image References)
[image1]: ./relative_dir/image.jpg "a name"
![alt text][image1]
  1. Open up markdown preview.
  2. Observe...
    screen shot 2017-10-16 at 11 45 50 am

Expected behavior: The image to be displayed.

Actual behavior: No image is shown. The console reports Failed to load resource: net::ERR_FILE_NOT_FOUND.

Reproduces how often: Without fail.

Versions

$ atom --version
Atom    : 1.21.1
Electron: 1.6.15
Chrome  : 56.0.2924.87
Node    : 7.4.0

markdown-preview version 0.159.15.

Additional Information

"Allow Unsafe Protocols" doesn't fix it.

@tterb
Copy link

tterb commented Oct 17, 2017

After reproducing this error using the provided markdown I initially received the same results, although I noticed that after reloading the window (View > Developer > Reload Window) the relative links began working as expected. If you reload the window do you get this same behavior?
If so, I can try to look a little deeper and see if I can pinpoint what could be causing this issue.

@enzinius
Copy link

Same problem here, images not shown in markdown preview.
After reproducing this issue I reload the window (View > Developer > Reload Window) and continue to get this same behavior.

@ckarras
Copy link

ckarras commented Oct 18, 2017

I had the same problem in Atom 1.21.1, I fixed it by uninstalling and re-installing version 1.21.0 instead.

View > Developer > Reload Window did not solve the problem.

@jiaweim
Copy link

jiaweim commented Oct 20, 2017

I had the same problem, and I fixed with by restart Atom,

@tterb
Copy link

tterb commented Oct 20, 2017

After seeing @ckarras comment, I tried the same markdown example on another computer that has v1.19 installed and can confirm that I didn't run into this issue.

@matths
Copy link

matths commented Oct 20, 2017

I can confirm that downgrading to 1.21.0 solved the problem for me as well.
When on 1.21.1 I used the inspector and I can add to the topic, that the image path was stating something like file:///Applications/Atom.app/Contents/Resources/app.asar/static/[relative path to image] as far a I remember. I might be wrong, but it might help debugging, maybe.

@rsese
Copy link

rsese commented Oct 20, 2017

Thanks for the reports everyone, I can reproduce as well with 1.21.1 on macOS 10.12.6 (but not on 1.21.0), I'll ask the team to take a look.

@ckarras
Copy link

ckarras commented Oct 25, 2017

Thanks for looking at this. Until this is resolved, is there a way to disable automatic updates of Atom? Every time I restart it, I see it has been upgraded to 1.21.1 (and the problem re-appears) and I have to re-downgrade it every time (which resolves the problem).

@nathansobo nathansobo self-assigned this Oct 25, 2017
@nathansobo
Copy link
Contributor

nathansobo commented Oct 25, 2017

@ckarras You can disable automatic updates from the About screen, accessible via the Application: About command in the command palette. Just uncheck the box.

screen shot 2017-10-25 at 1 15 18 pm

I'll be looking into this this afternoon and once I find the fix, I plan to release a hotfix. Sorry for the trouble everyone.

@nathansobo
Copy link
Contributor

This will be fixed in 1.21.2, which should be out soon.

@samuela
Copy link
Author

samuela commented Oct 26, 2017

Thanks @nathansobo !

@jrichardsz
Copy link

Confirmed , 1.21.0 solve the problem.

Steps :

HTH

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants