Absence of line between a list and a code block confuses Markdown Preview

[piroux]

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

The parser of markdown-preview seems to not recognize well the delimiter of a code block written directly after a list without any empty line, although it is properly handled on Github.
Actually, it seems like markdown-preview is trying to embed the code block at the list level but fail to recognize the end of the code block, whereas Github rendering makes the choice to render all code block outside of the list level.

Steps to Reproduce

1. Write the following gist in a new tab:
   https://gist.github.com/piroux/0caf3509cd000e254dab357025c9faf1
2. CTRL+SHIFT+M to activate the vanilla Markown Preview

Edit by @rsese - for step 1, copy paste this content

## ✅ on github.com ✅ on Atom with no line between a list and a code block

- abcd

```
efgh
---
- xyz
  123
```

## ✅ on github.com ❌ on Atom with no line between a list and a code block

- abcd
```
efgh
---
- xyz
  123
```

Expected behavior:

Preview on Atom should match the one offered by Github:

Actual behavior:

Reproduces how often:
Always

Versions

OS: Ubuntu 18.04 x64
Atom: 1.40.0
Electron: 3.1.10
Chrome: 66.0.3359.181
Node: v10.2.0

Additional Information

Other issues related to code preview already filed here:

• Empty line in code block in list breaks it #348
• Indented code block inside list gets rendered wrong #427
• Markdown Preview gets confused by ```language #530
• Markdown preview renders markdown line as a code block while Github does not do so #554

[rsese]

Thanks for the report! Reproduced with 1.42.0-nightly4 on 10.14.6.

[rsese]

Thanks again for the heads up about this - just wanted to mention that we looked at this again today and decided to close in favor of #342 if you want to subscribe there.