This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
🎨 lazy load git-utils since this is the only usage #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benogle Have any issues with this? |
|
I'd prefer we use the pattern we use elsewhere. Though I'm not sure if is actually any faster. Anyone know? GitUtils = null
constructor: ->
GitUtils ?= require 'git-utils'
GitUtils.func.... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is very unlikely that will give any performance gain. The main motivation I have is to use this package as a fork where I simply remove
git-utilsas a package dependency (as that needed a working node-gyp toolchain) and use this package as is without triggering the git-utils code path.I would completely understand if you want to disregard this PR 🌹 👍