LVM backend support for Cinder #300

wilkers-steve · 2017-03-22T15:52:26Z

Initial commit for adding LVM support for Cinder. Adds necessary
configuration files for supporting configuration of the backend

What is the purpose of this pull request?: Add support for LVM backend for Cinder

What issue does this pull request address?: Fixes #293

Notes for reviewers to consider:

Currently the configmaps for the LVM backend aren't handled with conditionals. This will change before the WIP tag gets removed.

Specific reviewers for pull request:

v1k0d3n · 2017-03-22T18:55:52Z

this is actually started as part of the development mode overrides (or improvement of development workflow), so it is an item on the 0.3.0 roadmap.

gardlt · 2017-03-24T01:18:30Z

cinder/templates/etc/_cinder.conf.tpl

+[lvm1]
+iscsi_helper = tgtadm
+iscsi_protocol = iscsi
+lvm_conf_file = /etc/cinder/lvm.conf


does this lvm.conf exist in the container, i dont see it in the template folder?

It doesn't exist, I think we can safely remove the reference to it: https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/lvm.py#L59-L64

Yep. This will be removed before the WIP tag comes off.

intlabs

@wilkers-steve This is an awesome bit of work, and a great start toward getting LVM up and running. I'll do a proper review tomorrow, once I've had time to mull over my thoughts on ways to implement the manifest, but a couple of things stick out at 1st parse.

intlabs · 2017-03-24T01:47:44Z

cinder/templates/deployment-volume.yaml

@@ -43,6 +43,9 @@ spec:
        {{ .Values.labels.node_selector_key }}: {{ .Values.labels.node_selector_value }}
      containers:
        - name: cinder-volume
+          securityContext:
+             privileged: true
+             runAsUser: 0


Now this is functional, we should be able to drop the privileges back down.

still running as root? i guess we can come back to each of these and run as non-root users when we get into the security context items (later near 0.6.0), but we need to keep track of them.

This will be removed with the next commit adding iSCSI to this PR.

well, to be fair...it's not the only one.i think privs and security is more of a project-wide security effort, and part of a later cleanup.

alanmeadows

Steve, great work. A few comments, but otherwise looks good to me. This will be fun incorporating into the config management framework and actually seems like a great next step since you're already deep into this chart.

alanmeadows · 2017-04-01T00:01:45Z

cinder/templates/etc/_cinder.conf.tpl

@@ -78,3 +85,18 @@ rbd_secret_uuid = {{- include "secrets/ceph-client-key" . -}}
 {{- end }}
 rbd_secret_uuid = {{ .Values.backends.rbd1.secret }}
 report_discard_supported = True
+{{ end }}
+
+{{ if .Values.lvm.enabled }}


@intlabs @wilkers-steve This is a comment for the future:

Although some of this may change when cinder gets a config override pass, this section (and ceph above) to me says a helm-toolkit function to take a yaml declaration and turn it into ini format would be useful in places like this. An equivalent of `{{ toYaml ...`` but geared towards oslo/ini.

This way you are not trying to provide overrides for every option possible, you give the end user the flexibility to target any known param, and add more.

Again, cinder config override stuff may account for some of this, but likely not all and we may still have a need to define backends much like Steve is doing here. We won't know until we see what an expanded cinder.conf contains from oslo config gen.

In any event, what I am describing is:

values.yaml:

lvm: config: iscsi_helper: tgtadm lvm_conf_file: /etc/cinder/lvm.conf ...

And then here:

{{ if .Values.lvm.enabled }} {{ tuple .Values.lvm.config | include "helm-toolkit.yaml_to_oslo" }} {{ end }}

@alanmeadows I like what you're describing. I agree that'd be a useful feature to have on hand when required.

alanmeadows · 2017-04-01T00:06:01Z

cinder/templates/etc/_rootwrap.conf.tpl

@@ -0,0 +1,27 @@
+# Configuration for cinder-rootwrap


Good addition Steve. @v1k0d3n We likely need a feature to account for _rootwrap.conf.tpl consistency across the board. This is the first (welcomed) introduction. This is inline with me bringing in policy.json and paste everywhere.

alanmeadows · 2017-04-01T00:10:04Z

cinder/values.yaml

@@ -153,6 +156,169 @@ dependencies:
    - keystone-api
    - cinder-api

+mounts:


You did awesome laborious work here Steve. There was a change of approach for mounts to make the .Values storage for them simply append as opposed to housing all mounts per #319. This means users cannot "undo" our mounts but they can add it does make values.yaml a bit smaller and keeps the mounts we need closer to the actual manifest. This is of course my fault for sending you down this path and then changing course after this PR.

We can either move these back into the manifests and copy #319 in a separate PR or update them here. Totally up to you.

@alanmeadows Thanks for the feedback. I can move these back to the manifests in this pull request.

wilkers-steve · 2017-04-03T12:16:22Z

@alanmeadows @v1k0d3n @intlabs I've changed the mounts to function similarly to #319. The only snowflake was cinder-volume, but we can address how to conditionally handle backend-specific mounts as we move forward

intlabs

Steve, this looks awesome. I think we should also provide iSCSI as part of this PR, so that the volumes can actually be consumed. As soon as that's in I think we should be good to merge. :)

This adds the ability for cinder to use LVM as a backend

v1k0d3n · 2017-04-07T21:26:55Z

@wilkers-steve is PR this in or out for openstack?

wilkers-steve · 2017-04-07T21:30:38Z

@v1k0d3n I would say it could go either way. I wouldn't let this block the -1 workflow on the patchset for moving into OpenStack. If I get the iscsi bits added before the +2 happens for moving into infra, we can go ahead and merge it in. If it doesn't, I'll add the work in once we move into OpenStack

wilkers-steve · 2017-04-10T16:59:08Z

Lets get this in once we're in OpenStack.

v1k0d3n · 2017-04-13T20:54:30Z

closing this PR in favor of moving the work to Openstack proper: https://github.com/openstack/openstack-helm

v1k0d3n added the in progress label Mar 22, 2017

v1k0d3n added this to the 0.3.0 milestone Mar 22, 2017

v1k0d3n added the developer workflow label Mar 22, 2017

v1k0d3n requested review from alanmeadows, intlabs and v1k0d3n March 22, 2017 18:56

v1k0d3n assigned wilkers-steve Mar 22, 2017

gardlt reviewed Mar 24, 2017

View reviewed changes

intlabs suggested changes Mar 24, 2017

View reviewed changes

wilkers-steve force-pushed the cinder_lvm_support branch 2 times, most recently from 02d557e to 8d9836e Compare March 27, 2017 18:11

wilkers-steve changed the title ~~WIP: LVM backend support for Cinder~~ LVM backend support for Cinder Mar 27, 2017

v1k0d3n added the needs core review label Mar 29, 2017

alanmeadows approved these changes Apr 1, 2017

View reviewed changes

v1k0d3n mentioned this pull request Apr 3, 2017

feat: Support Cinder multibackend configs. #321

Open

wilkers-steve force-pushed the cinder_lvm_support branch 2 times, most recently from 5226b6e to 60a99bf Compare April 3, 2017 12:15

powerds mentioned this pull request Apr 3, 2017

feat: Support to choose openstack backend plugins #320

Open

intlabs approved these changes Apr 4, 2017

View reviewed changes

intlabs suggested changes Apr 4, 2017

View reviewed changes

larryrensing mentioned this pull request Apr 6, 2017

Feat: bootstrap services cinder #318

Closed

wilkers-steve force-pushed the cinder_lvm_support branch from 60a99bf to 89603bc Compare April 7, 2017 15:57

Cinder LVM Support

fc88837

This adds the ability for cinder to use LVM as a backend

wilkers-steve force-pushed the cinder_lvm_support branch from 89603bc to fc88837 Compare April 7, 2017 19:50

v1k0d3n added the IMPORT PROBABLE label Apr 7, 2017

wilkers-steve added DO NOT MERGE and removed developer workflow IMPORT PROBABLE in progress needs core review labels Apr 10, 2017

v1k0d3n closed this Apr 13, 2017

v1k0d3n added the ORPHANED label Apr 13, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LVM backend support for Cinder #300

LVM backend support for Cinder #300

wilkers-steve commented Mar 22, 2017

v1k0d3n commented Mar 22, 2017

gardlt Mar 24, 2017

intlabs Mar 24, 2017

wilkers-steve Mar 24, 2017

intlabs left a comment

intlabs Mar 24, 2017

v1k0d3n Apr 4, 2017 •

edited

Loading

wilkers-steve Apr 4, 2017

v1k0d3n Apr 4, 2017

alanmeadows left a comment

alanmeadows Apr 1, 2017

wilkers-steve Apr 1, 2017

alanmeadows Apr 1, 2017

alanmeadows Apr 1, 2017

wilkers-steve Apr 1, 2017

wilkers-steve commented Apr 3, 2017

intlabs left a comment

v1k0d3n commented Apr 7, 2017

wilkers-steve commented Apr 7, 2017

wilkers-steve commented Apr 10, 2017

v1k0d3n commented Apr 13, 2017

LVM backend support for Cinder #300

LVM backend support for Cinder #300

Conversation

wilkers-steve commented Mar 22, 2017

v1k0d3n commented Mar 22, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

intlabs left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

v1k0d3n Apr 4, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alanmeadows left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wilkers-steve commented Apr 3, 2017

intlabs left a comment

Choose a reason for hiding this comment

v1k0d3n commented Apr 7, 2017

wilkers-steve commented Apr 7, 2017

wilkers-steve commented Apr 10, 2017

v1k0d3n commented Apr 13, 2017

v1k0d3n Apr 4, 2017 •

edited

Loading