Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input values are not cleared #17

Closed
ozooner opened this issue Jan 8, 2017 · 4 comments
Closed

Input values are not cleared #17

ozooner opened this issue Jan 8, 2017 · 4 comments
Labels
closed:stale Issue or PR has not seen activity recently

Comments

@ozooner
Copy link

ozooner commented Jan 8, 2017

Hi,

This issue is specific to popup mode login, as there is no redirection, the auth0 lock instance will remain in browser memory. Due to that nuance, when user logs out, and opens the log-in window again (rememberLastLogin disabled), the input fields in the lock remain from previous login.
I decided that angular-lock would be more fitting repo for this issue, as with the original lock I could create new instance of the lock every time the button is pressed, however with angular, there is only single lock instance created with app initialization.
Video explains better: https://youtu.be/frPcOG40C-s

Regards,
ozooner

@chenkie
Copy link
Contributor

chenkie commented Jan 11, 2017

Are you needing to create a new instance for any other reason than just to clear the input fields? If not, I think we should look at a different approach/fix. Creating a new instance every time seems unnecessary.

@ozooner
Copy link
Author

ozooner commented Jan 11, 2017

No, ideally the lock would clear the input values once authentication is successful.
I was just implying that creating new lock instance would be a 'quick fix' if I was using the plain lock file, however since angular-lock only creates one instance of lock, I can't even do that...

@chenkie
Copy link
Contributor

chenkie commented Jan 11, 2017

I've submitted an issue for this in the Lock repo: auth0/lock#795

Stay tuned there for a change there.

@stale
Copy link

stale bot commented Oct 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇‍♂️

@stale stale bot added the closed:stale Issue or PR has not seen activity recently label Oct 23, 2019
@stale stale bot closed this as completed Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed:stale Issue or PR has not seen activity recently
Projects
None yet
Development

No branches or pull requests

2 participants