Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWTVerifier with varargs is ambiguous #39

Closed
tenjaa opened this issue Nov 26, 2019 · 4 comments
Closed

JWTVerifier with varargs is ambiguous #39

tenjaa opened this issue Nov 26, 2019 · 4 comments

Comments

@tenjaa
Copy link

tenjaa commented Nov 26, 2019

Hey,
we ran into an issue that is described in another project of your org.
auth0/java-jwt#344

An backwards compatible fix would probably be to provide another constructor.
But I doubt that anyone should be passing null into the audience, as it is just not working as expected.
So changing the construcor param to varargs and then handling it could also be an option.

Tell me what you think and I am happy to provide a pull request.

@stale
Copy link

stale bot commented Feb 24, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇‍♂️

@stale stale bot added the closed:stale Issue or PR has not seen activity recently label Feb 24, 2020
@tenjaa
Copy link
Author

tenjaa commented Feb 24, 2020

I don't think that's resolved yet

@stale stale bot removed the closed:stale Issue or PR has not seen activity recently label Feb 24, 2020
@ssrm
Copy link

ssrm commented Mar 10, 2020

I also ran into same issue, I have kept a pull request on java-jwt project, have to see what will happen to that pr.

@jimmyjames jimmyjames added the needs investigation An issue that has more questions to answer or otherwise needs work to fully understand the issue label Apr 13, 2020
@jimmyjames
Copy link
Contributor

I've verified that this issue is resolved. It was fixed in the java-jwt library by this PR. If you are using version 1.3.1 or later of this library and still seeing this issue, please reopen so we can investigate further. Thanks!

@jimmyjames jimmyjames removed the needs investigation An issue that has more questions to answer or otherwise needs work to fully understand the issue label Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants