Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clock is package private [3.0.1] #118

Closed
chadjaros opened this issue Dec 9, 2016 · 3 comments
Closed

Clock is package private [3.0.1] #118

chadjaros opened this issue Dec 9, 2016 · 3 comments

Comments

@chadjaros
Copy link

Should the Clock class, and JWTVerifier#build method be public instead of package private? Making these package private doesn't do me any good if I want to use a custom clock for unit testing.
@chadjaros
Copy link
Author

Related to #50

@hzalaz
Copy link
Member

hzalaz commented Dec 9, 2016

Might be a good idea. Will have to review the API to make this possible. PRs are always welcomed, we were busy handling other work but we'll try to be up to date with them

@lbalmaceda lbalmaceda mentioned this issue Dec 16, 2016
Merged
@lbalmaceda
Copy link
Contributor

Available in version 3.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hzalaz @lbalmaceda @chadjaros