Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve testability by extracting an interface for JWTVerifier #192

Closed
mcantrell opened this issue Aug 5, 2017 · 3 comments
Closed

Improve testability by extracting an interface for JWTVerifier #192

mcantrell opened this issue Aug 5, 2017 · 3 comments

Comments

@mcantrell
Copy link

For the sake of unit testing, it would be nice if there was an an interface extracted from the implementation.
@jebbench
Copy link

I have also run into the same issue; and since the class is final I can't mock it either.

@jebbench jebbench mentioned this issue Sep 27, 2017
Merged
@lbalmaceda
Copy link
Contributor

Would it help making the class non-final?

@mcantrell
Copy link
Author

That would solve my testing problem for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mcantrell @jebbench @lbalmaceda