-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JDK links to Javadoc #489
Comments
This is a good addition. Although, I'd like us to include it in our OSS release plugin instead, in a generic way. Probably using the JDK toolchain. I see in the code you are passing the minimum java version for this project, I'd assume that the value would be available exposed as property through the java gradle plugin, for example. Let me share this internally for more visibility. |
Would you like to send a PR with those changes you linked? The snippet below would need to go into the // Use latest JDK for javadoc generation
tasks.withType(Javadoc).configureEach {
javadocTool = javaToolchains.javadocToolFor {
languageVersion = JavaLanguageVersion.of(16)
}
}
javadoc {
// Exclude internal implementation package from javadoc
excludes = ['com/auth0/jwt/impl']
// Specify Java version this project uses
options.addStringOption('-release', '8')
} |
Do you mean the root
In most cases this probably does not make a difference. However, there can be cases where |
Describe the problem you'd like to have solved
Currently the javadoc has no links to JDK classes, e.g.
java.lang.Object
. This makes browsing it slightly inconvenient.Describe the ideal solution
This could be solved by specifying the JDK link the Gradle build file:
Alternatives and current work-arounds
Alternatively, or additionally you could also specify a JDK toolchain only for the javadoc task which takes advantages of the lastest JDK javadoc features (such as a search bar), without having to change the lowest Java version this projects supports.
I have implemented an experimental implementation for this here (this also partially addresses #487), feel free to try it out:
gradlew javadoc
lib/build/docs/javadoc/index.html
in your browserI don't have much experience with Gradle, so I am not sure if this is properly implemented. However, let me know if I should create a pull request for the branch.
The text was updated successfully, but these errors were encountered: