-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing Java LTS versions #536
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmyjames
suggested changes
Mar 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just requested that you remove the unused Ignore
import since we're excluding for java 17 only now.
lib/src/test/java/com/auth0/jwt/algorithms/ECDSAAlgorithmTest.java
Outdated
Show resolved
Hide resolved
jimmyjames
approved these changes
Mar 7, 2022
poovamraj
added a commit
that referenced
this pull request
Mar 16, 2022
* Added Gradle Tasks to run tests on Java LTS versions * Ignore secp256k1 curve tests * Removing ignore for tests and checking the CI failure * Exclude secp256k1 Tests for Java 17 * Remove unwanted "ignore" imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Please describe both what is changing and why this is important. Include:
toolVersion
is explicitly mentioned since Java 17 is provided only above the specified versionReferences
Jacoco Release note mentioning Java 17 support - https://www.jacoco.org/jacoco/trunk/doc/changes.html
Java dropping support for secp256k1 curve - https://www.oracle.com/java/technologies/javase/15-relnote-issues.html#JDK-8237219
Testing