From 030c685a07d125b2eac813daaa222b8bd1631cf2 Mon Sep 17 00:00:00 2001 From: Poovamraj T T Date: Fri, 4 Mar 2022 16:17:55 +0530 Subject: [PATCH 1/5] Added Gradle Tasks to run tests on Java LTS versions --- lib/build.gradle | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/lib/build.gradle b/lib/build.gradle index e1a4b4e7..bb9308c2 100644 --- a/lib/build.gradle +++ b/lib/build.gradle @@ -55,6 +55,10 @@ dependencies { testImplementation 'org.mockito:mockito-core:2.18.3' } +jacoco { + toolVersion = "0.8.7" +} + jacocoTestReport { reports { xml.enabled = true @@ -87,6 +91,35 @@ task compileModuleInfoJava(type: JavaCompile) { } } +compileTestJava { + options.compilerArgs = ['--release', "8"] +} + +def testJava8 = tasks.register('testJava8', Test) { + description = 'Runs unit tests on Java 8.' + group = 'verification' + + javaLauncher.set(javaToolchains.launcherFor { + languageVersion = JavaLanguageVersion.of(8) + }) + shouldRunAfter(tasks.named('test')) +} + +def testJava17 = tasks.register('testJava17', Test) { + description = 'Runs unit tests on Java 17.' + group = 'verification' + + javaLauncher.set(javaToolchains.launcherFor { + languageVersion = JavaLanguageVersion.of(17) + }) + shouldRunAfter(tasks.named('test')) +} + +tasks.named('check') { + dependsOn(testJava8) + dependsOn(testJava17) +} + jar { manifest.attributes('Multi-Release': 'true') } From ee1265cbf9ed5ab2ecf478cebe75fbb347659c12 Mon Sep 17 00:00:00 2001 From: Poovamraj T T Date: Fri, 4 Mar 2022 16:25:00 +0530 Subject: [PATCH 2/5] Ignore secp256k1 curve tests --- lib/src/test/java/com/auth0/jwt/ConcurrentVerifyTest.java | 6 ++---- lib/src/test/java/com/auth0/jwt/JWTCreatorTest.java | 3 +++ lib/src/test/java/com/auth0/jwt/JWTTest.java | 2 ++ .../java/com/auth0/jwt/algorithms/ECDSAAlgorithmTest.java | 4 ++++ .../jwt/algorithms/ECDSABouncyCastleProviderTests.java | 7 +++---- 5 files changed, 14 insertions(+), 8 deletions(-) diff --git a/lib/src/test/java/com/auth0/jwt/ConcurrentVerifyTest.java b/lib/src/test/java/com/auth0/jwt/ConcurrentVerifyTest.java index f4de1f71..7af0a8d7 100644 --- a/lib/src/test/java/com/auth0/jwt/ConcurrentVerifyTest.java +++ b/lib/src/test/java/com/auth0/jwt/ConcurrentVerifyTest.java @@ -3,10 +3,7 @@ import com.auth0.jwt.algorithms.Algorithm; import com.auth0.jwt.interfaces.DecodedJWT; import net.jodah.concurrentunit.Waiter; -import org.junit.AfterClass; -import org.junit.BeforeClass; -import org.junit.Rule; -import org.junit.Test; +import org.junit.*; import org.junit.rules.ExpectedException; import java.security.interfaces.ECKey; @@ -146,6 +143,7 @@ public void shouldPassECDSA256VerificationWithJOSESignature() throws Exception { } @Test + @Ignore //todo: handle ecdsa curve secp256k1 disabled in Java 15+ public void shouldPassECDSA256KVerificationWithJOSESignature() throws Exception { String token = "eyJraWQiOiJteS1rZXktaWQiLCJ0eXAiOiJKV1QiLCJhbGciOiJFUzI1NksifQ.eyJpc3MiOiJhdXRoMCJ9.W-AbsnuQ4vqmPftAyQuF09hn3oGn3tN7VGergxyMbK74yEzDV-mLyC3o3fxXrZxcW5h01DM6BckNag7ZcimPjw"; ECPublicKey publicKey = (ECPublicKey) readPublicKeyFromFile(PUBLIC_KEY_FILE_256K, "EC"); diff --git a/lib/src/test/java/com/auth0/jwt/JWTCreatorTest.java b/lib/src/test/java/com/auth0/jwt/JWTCreatorTest.java index 0cbafc35..98431b09 100644 --- a/lib/src/test/java/com/auth0/jwt/JWTCreatorTest.java +++ b/lib/src/test/java/com/auth0/jwt/JWTCreatorTest.java @@ -6,6 +6,7 @@ import com.auth0.jwt.interfaces.RSAKeyProvider; import com.fasterxml.jackson.databind.ObjectMapper; +import org.junit.Ignore; import org.junit.Rule; import org.junit.Test; import org.junit.rules.ExpectedException; @@ -158,6 +159,7 @@ public void shouldNotOverwriteKeyIdIfAddedFromRSAAlgorithms() throws Exception { } @Test + @Ignore //todo: handle ecdsa curve secp256k1 disabled in Java 15+ public void shouldAddKeyIdIfAvailableFromECDSAKAlgorithms() throws Exception { ECPrivateKey privateKey = (ECPrivateKey) PemUtils.readPrivateKeyFromFile(PRIVATE_KEY_FILE_EC_256K, "EC"); ECDSAKeyProvider provider = mock(ECDSAKeyProvider.class); @@ -174,6 +176,7 @@ public void shouldAddKeyIdIfAvailableFromECDSAKAlgorithms() throws Exception { } @Test + @Ignore //todo: handle ecdsa curve secp256k1 disabled in Java 15+ public void shouldNotOverwriteKeyIdIfAddedFromECDSAKAlgorithms() throws Exception { ECPrivateKey privateKey = (ECPrivateKey) PemUtils.readPrivateKeyFromFile(PRIVATE_KEY_FILE_EC_256K, "EC"); ECDSAKeyProvider provider = mock(ECDSAKeyProvider.class); diff --git a/lib/src/test/java/com/auth0/jwt/JWTTest.java b/lib/src/test/java/com/auth0/jwt/JWTTest.java index 20bb384b..47307ae3 100644 --- a/lib/src/test/java/com/auth0/jwt/JWTTest.java +++ b/lib/src/test/java/com/auth0/jwt/JWTTest.java @@ -4,6 +4,7 @@ import com.auth0.jwt.interfaces.DecodedJWT; import org.hamcrest.collection.IsCollectionWithSize; import org.hamcrest.core.IsCollectionContaining; +import org.junit.Ignore; import org.junit.Rule; import org.junit.Test; import org.junit.rules.ExpectedException; @@ -498,6 +499,7 @@ public void shouldCreateAnEmptyECDSA256SignedToken() throws Exception { } @Test + @Ignore //todo: handle ecdsa curve secp256k1 disabled in Java 15+ public void shouldCreateAnEmptyECDSA256KSignedToken() throws Exception { ECPublicKey publicKey = (ECPublicKey) PemUtils.readPublicKeyFromFile(PUBLIC_KEY_FILE_EC_256K, "EC"); ECPrivateKey privateKey = (ECPrivateKey) PemUtils.readPrivateKeyFromFile(PRIVATE_KEY_FILE_EC_256K, "EC"); diff --git a/lib/src/test/java/com/auth0/jwt/algorithms/ECDSAAlgorithmTest.java b/lib/src/test/java/com/auth0/jwt/algorithms/ECDSAAlgorithmTest.java index 8dd00ca3..4b07152b 100644 --- a/lib/src/test/java/com/auth0/jwt/algorithms/ECDSAAlgorithmTest.java +++ b/lib/src/test/java/com/auth0/jwt/algorithms/ECDSAAlgorithmTest.java @@ -6,6 +6,7 @@ import com.auth0.jwt.interfaces.ECDSAKeyProvider; import org.hamcrest.Matchers; import org.hamcrest.collection.IsIn; +import org.junit.Ignore; import org.junit.Rule; import org.junit.Test; import org.junit.rules.ExpectedException; @@ -188,6 +189,7 @@ public void shouldFailECDSA256VerificationOnInvalidDERSignature() throws Excepti } @Test + @Ignore //todo: handle ecdsa curve secp256k1 disabled in Java 15+ public void shouldPassECDSA256KVerificationWithJOSESignature() throws Exception { ECPublicKey key = (ECPublicKey) readPublicKeyFromFile(PUBLIC_KEY_FILE_256K, "EC"); Algorithm algorithm = Algorithm.ECDSA256K(key, null); @@ -209,6 +211,7 @@ public void shouldThrowOnECDSA256KVerificationWithDERSignature() throws Exceptio } @Test + @Ignore //todo: handle ecdsa curve secp256k1 disabled in Java 15+ public void shouldPassECDSA256KVerificationWithJOSESignatureWithBothKeys() throws Exception { Algorithm algorithm = Algorithm.ECDSA256K((ECPublicKey) readPublicKeyFromFile(PUBLIC_KEY_FILE_256K, "EC") , (ECPrivateKey) readPrivateKeyFromFile(PRIVATE_KEY_FILE_256K, "EC")); @@ -216,6 +219,7 @@ public void shouldPassECDSA256KVerificationWithJOSESignatureWithBothKeys() throw } @Test + @Ignore //todo: handle ecdsa curve secp256k1 disabled in Java 15+ public void shouldPassECDSA256KVerificationWithProvidedPublicKey() throws Exception { ECDSAKeyProvider provider = mock(ECDSAKeyProvider.class); PublicKey publicKey = readPublicKeyFromFile(PUBLIC_KEY_FILE_256K, "EC"); diff --git a/lib/src/test/java/com/auth0/jwt/algorithms/ECDSABouncyCastleProviderTests.java b/lib/src/test/java/com/auth0/jwt/algorithms/ECDSABouncyCastleProviderTests.java index 675baeff..1959a76c 100644 --- a/lib/src/test/java/com/auth0/jwt/algorithms/ECDSABouncyCastleProviderTests.java +++ b/lib/src/test/java/com/auth0/jwt/algorithms/ECDSABouncyCastleProviderTests.java @@ -5,10 +5,7 @@ import com.auth0.jwt.exceptions.SignatureVerificationException; import com.auth0.jwt.interfaces.ECDSAKeyProvider; import org.bouncycastle.jce.provider.BouncyCastleProvider; -import org.junit.AfterClass; -import org.junit.BeforeClass; -import org.junit.Rule; -import org.junit.Test; +import org.junit.*; import org.junit.rules.ExpectedException; import java.nio.charset.StandardCharsets; @@ -102,6 +99,7 @@ public void shouldThrowOnECDSA256KVerificationWithDERSignature() throws Exceptio } @Test + @Ignore //todo: handle curve secp256k1 disabled in Java 15+ public void shouldPassECDSA256KVerificationWithJOSESignatureWithBothKeys() throws Exception { Algorithm algorithm = Algorithm.ECDSA256K((ECPublicKey) readPublicKeyFromFile(PUBLIC_KEY_FILE_256K, "EC") , (ECPrivateKey) readPrivateKeyFromFile(PRIVATE_KEY_FILE_256K, "EC")); @@ -109,6 +107,7 @@ public void shouldPassECDSA256KVerificationWithJOSESignatureWithBothKeys() throw } @Test + @Ignore //todo: handle curve secp256k1 disabled in Java 15+ public void shouldPassECDSA256KVerificationWithProvidedPublicKey() throws Exception { ECDSAKeyProvider provider = mock(ECDSAKeyProvider.class); PublicKey publicKey = readPublicKeyFromFile(PUBLIC_KEY_FILE_256K, "EC"); From 4dcfe4a18d7d738ddb8d8b1aa70252c8e7ca23e5 Mon Sep 17 00:00:00 2001 From: Poovamraj T T Date: Fri, 4 Mar 2022 21:48:52 +0530 Subject: [PATCH 3/5] Removing ignore for tests and checking the CI failure --- lib/src/test/java/com/auth0/jwt/ConcurrentVerifyTest.java | 1 - lib/src/test/java/com/auth0/jwt/JWTCreatorTest.java | 2 -- lib/src/test/java/com/auth0/jwt/JWTTest.java | 1 - .../test/java/com/auth0/jwt/algorithms/ECDSAAlgorithmTest.java | 3 --- .../auth0/jwt/algorithms/ECDSABouncyCastleProviderTests.java | 2 -- 5 files changed, 9 deletions(-) diff --git a/lib/src/test/java/com/auth0/jwt/ConcurrentVerifyTest.java b/lib/src/test/java/com/auth0/jwt/ConcurrentVerifyTest.java index 7af0a8d7..0f569fae 100644 --- a/lib/src/test/java/com/auth0/jwt/ConcurrentVerifyTest.java +++ b/lib/src/test/java/com/auth0/jwt/ConcurrentVerifyTest.java @@ -143,7 +143,6 @@ public void shouldPassECDSA256VerificationWithJOSESignature() throws Exception { } @Test - @Ignore //todo: handle ecdsa curve secp256k1 disabled in Java 15+ public void shouldPassECDSA256KVerificationWithJOSESignature() throws Exception { String token = "eyJraWQiOiJteS1rZXktaWQiLCJ0eXAiOiJKV1QiLCJhbGciOiJFUzI1NksifQ.eyJpc3MiOiJhdXRoMCJ9.W-AbsnuQ4vqmPftAyQuF09hn3oGn3tN7VGergxyMbK74yEzDV-mLyC3o3fxXrZxcW5h01DM6BckNag7ZcimPjw"; ECPublicKey publicKey = (ECPublicKey) readPublicKeyFromFile(PUBLIC_KEY_FILE_256K, "EC"); diff --git a/lib/src/test/java/com/auth0/jwt/JWTCreatorTest.java b/lib/src/test/java/com/auth0/jwt/JWTCreatorTest.java index 98431b09..8fae69ef 100644 --- a/lib/src/test/java/com/auth0/jwt/JWTCreatorTest.java +++ b/lib/src/test/java/com/auth0/jwt/JWTCreatorTest.java @@ -159,7 +159,6 @@ public void shouldNotOverwriteKeyIdIfAddedFromRSAAlgorithms() throws Exception { } @Test - @Ignore //todo: handle ecdsa curve secp256k1 disabled in Java 15+ public void shouldAddKeyIdIfAvailableFromECDSAKAlgorithms() throws Exception { ECPrivateKey privateKey = (ECPrivateKey) PemUtils.readPrivateKeyFromFile(PRIVATE_KEY_FILE_EC_256K, "EC"); ECDSAKeyProvider provider = mock(ECDSAKeyProvider.class); @@ -176,7 +175,6 @@ public void shouldAddKeyIdIfAvailableFromECDSAKAlgorithms() throws Exception { } @Test - @Ignore //todo: handle ecdsa curve secp256k1 disabled in Java 15+ public void shouldNotOverwriteKeyIdIfAddedFromECDSAKAlgorithms() throws Exception { ECPrivateKey privateKey = (ECPrivateKey) PemUtils.readPrivateKeyFromFile(PRIVATE_KEY_FILE_EC_256K, "EC"); ECDSAKeyProvider provider = mock(ECDSAKeyProvider.class); diff --git a/lib/src/test/java/com/auth0/jwt/JWTTest.java b/lib/src/test/java/com/auth0/jwt/JWTTest.java index 47307ae3..ddca329d 100644 --- a/lib/src/test/java/com/auth0/jwt/JWTTest.java +++ b/lib/src/test/java/com/auth0/jwt/JWTTest.java @@ -499,7 +499,6 @@ public void shouldCreateAnEmptyECDSA256SignedToken() throws Exception { } @Test - @Ignore //todo: handle ecdsa curve secp256k1 disabled in Java 15+ public void shouldCreateAnEmptyECDSA256KSignedToken() throws Exception { ECPublicKey publicKey = (ECPublicKey) PemUtils.readPublicKeyFromFile(PUBLIC_KEY_FILE_EC_256K, "EC"); ECPrivateKey privateKey = (ECPrivateKey) PemUtils.readPrivateKeyFromFile(PRIVATE_KEY_FILE_EC_256K, "EC"); diff --git a/lib/src/test/java/com/auth0/jwt/algorithms/ECDSAAlgorithmTest.java b/lib/src/test/java/com/auth0/jwt/algorithms/ECDSAAlgorithmTest.java index 4b07152b..30a3efaf 100644 --- a/lib/src/test/java/com/auth0/jwt/algorithms/ECDSAAlgorithmTest.java +++ b/lib/src/test/java/com/auth0/jwt/algorithms/ECDSAAlgorithmTest.java @@ -189,7 +189,6 @@ public void shouldFailECDSA256VerificationOnInvalidDERSignature() throws Excepti } @Test - @Ignore //todo: handle ecdsa curve secp256k1 disabled in Java 15+ public void shouldPassECDSA256KVerificationWithJOSESignature() throws Exception { ECPublicKey key = (ECPublicKey) readPublicKeyFromFile(PUBLIC_KEY_FILE_256K, "EC"); Algorithm algorithm = Algorithm.ECDSA256K(key, null); @@ -211,7 +210,6 @@ public void shouldThrowOnECDSA256KVerificationWithDERSignature() throws Exceptio } @Test - @Ignore //todo: handle ecdsa curve secp256k1 disabled in Java 15+ public void shouldPassECDSA256KVerificationWithJOSESignatureWithBothKeys() throws Exception { Algorithm algorithm = Algorithm.ECDSA256K((ECPublicKey) readPublicKeyFromFile(PUBLIC_KEY_FILE_256K, "EC") , (ECPrivateKey) readPrivateKeyFromFile(PRIVATE_KEY_FILE_256K, "EC")); @@ -219,7 +217,6 @@ public void shouldPassECDSA256KVerificationWithJOSESignatureWithBothKeys() throw } @Test - @Ignore //todo: handle ecdsa curve secp256k1 disabled in Java 15+ public void shouldPassECDSA256KVerificationWithProvidedPublicKey() throws Exception { ECDSAKeyProvider provider = mock(ECDSAKeyProvider.class); PublicKey publicKey = readPublicKeyFromFile(PUBLIC_KEY_FILE_256K, "EC"); diff --git a/lib/src/test/java/com/auth0/jwt/algorithms/ECDSABouncyCastleProviderTests.java b/lib/src/test/java/com/auth0/jwt/algorithms/ECDSABouncyCastleProviderTests.java index 1959a76c..6b0266a4 100644 --- a/lib/src/test/java/com/auth0/jwt/algorithms/ECDSABouncyCastleProviderTests.java +++ b/lib/src/test/java/com/auth0/jwt/algorithms/ECDSABouncyCastleProviderTests.java @@ -99,7 +99,6 @@ public void shouldThrowOnECDSA256KVerificationWithDERSignature() throws Exceptio } @Test - @Ignore //todo: handle curve secp256k1 disabled in Java 15+ public void shouldPassECDSA256KVerificationWithJOSESignatureWithBothKeys() throws Exception { Algorithm algorithm = Algorithm.ECDSA256K((ECPublicKey) readPublicKeyFromFile(PUBLIC_KEY_FILE_256K, "EC") , (ECPrivateKey) readPrivateKeyFromFile(PRIVATE_KEY_FILE_256K, "EC")); @@ -107,7 +106,6 @@ public void shouldPassECDSA256KVerificationWithJOSESignatureWithBothKeys() throw } @Test - @Ignore //todo: handle curve secp256k1 disabled in Java 15+ public void shouldPassECDSA256KVerificationWithProvidedPublicKey() throws Exception { ECDSAKeyProvider provider = mock(ECDSAKeyProvider.class); PublicKey publicKey = readPublicKeyFromFile(PUBLIC_KEY_FILE_256K, "EC"); From 9c2d51f3a408dee49545b471a07f3957b4089b3d Mon Sep 17 00:00:00 2001 From: Poovamraj T T Date: Fri, 4 Mar 2022 22:44:20 +0530 Subject: [PATCH 4/5] Exclude secp256k1 Tests for Java 17 --- lib/build.gradle | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/lib/build.gradle b/lib/build.gradle index bb9308c2..2bb5c599 100644 --- a/lib/build.gradle +++ b/lib/build.gradle @@ -113,6 +113,19 @@ def testJava17 = tasks.register('testJava17', Test) { languageVersion = JavaLanguageVersion.of(17) }) shouldRunAfter(tasks.named('test')) + + //Following Tests are excluded in Java 17 since secp256k1 curve is disabled Java 15+ + filter { + excludeTestsMatching "*.jwt.ConcurrentVerifyTest.shouldPassECDSA256KVerificationWithJOSESignature" + excludeTestsMatching "*.jwt.JWTCreatorTest.shouldAddKeyIdIfAvailableFromECDSAKAlgorithms" + excludeTestsMatching "*.jwt.JWTCreatorTest.shouldNotOverwriteKeyIdIfAddedFromECDSAKAlgorithms" + excludeTestsMatching "*.jwt.JWTTest.shouldCreateAnEmptyECDSA256KSignedToken" + excludeTestsMatching "*.jwt.algorithms.ECDSAAlgorithmTest.shouldPassECDSA256KVerificationWithJOSESignature" + excludeTestsMatching "*.jwt.algorithms.ECDSAAlgorithmTest.shouldPassECDSA256KVerificationWithJOSESignatureWithBothKeys" + excludeTestsMatching "*.jwt.algorithms.ECDSAAlgorithmTest.shouldPassECDSA256KVerificationWithProvidedPublicKey" + excludeTestsMatching "*.jwt.ECDSABouncyCastleProviderTests.shouldPassECDSA256KVerificationWithJOSESignatureWithBothKeys" + excludeTestsMatching "*.jwt.ECDSABouncyCastleProviderTests.shouldPassECDSA256KVerificationWithProvidedPublicKey" + } } tasks.named('check') { From da4a094fb5a9d70dd0e55672d153b1d9f338ebd8 Mon Sep 17 00:00:00 2001 From: Poovamraj T T Date: Mon, 7 Mar 2022 17:45:08 +0530 Subject: [PATCH 5/5] Remove unwanted "ignore" imports --- lib/src/test/java/com/auth0/jwt/ConcurrentVerifyTest.java | 5 ++++- lib/src/test/java/com/auth0/jwt/JWTCreatorTest.java | 1 - lib/src/test/java/com/auth0/jwt/JWTTest.java | 1 - .../java/com/auth0/jwt/algorithms/ECDSAAlgorithmTest.java | 1 - .../auth0/jwt/algorithms/ECDSABouncyCastleProviderTests.java | 5 ++++- 5 files changed, 8 insertions(+), 5 deletions(-) diff --git a/lib/src/test/java/com/auth0/jwt/ConcurrentVerifyTest.java b/lib/src/test/java/com/auth0/jwt/ConcurrentVerifyTest.java index 0f569fae..f4de1f71 100644 --- a/lib/src/test/java/com/auth0/jwt/ConcurrentVerifyTest.java +++ b/lib/src/test/java/com/auth0/jwt/ConcurrentVerifyTest.java @@ -3,7 +3,10 @@ import com.auth0.jwt.algorithms.Algorithm; import com.auth0.jwt.interfaces.DecodedJWT; import net.jodah.concurrentunit.Waiter; -import org.junit.*; +import org.junit.AfterClass; +import org.junit.BeforeClass; +import org.junit.Rule; +import org.junit.Test; import org.junit.rules.ExpectedException; import java.security.interfaces.ECKey; diff --git a/lib/src/test/java/com/auth0/jwt/JWTCreatorTest.java b/lib/src/test/java/com/auth0/jwt/JWTCreatorTest.java index 8fae69ef..0cbafc35 100644 --- a/lib/src/test/java/com/auth0/jwt/JWTCreatorTest.java +++ b/lib/src/test/java/com/auth0/jwt/JWTCreatorTest.java @@ -6,7 +6,6 @@ import com.auth0.jwt.interfaces.RSAKeyProvider; import com.fasterxml.jackson.databind.ObjectMapper; -import org.junit.Ignore; import org.junit.Rule; import org.junit.Test; import org.junit.rules.ExpectedException; diff --git a/lib/src/test/java/com/auth0/jwt/JWTTest.java b/lib/src/test/java/com/auth0/jwt/JWTTest.java index ddca329d..20bb384b 100644 --- a/lib/src/test/java/com/auth0/jwt/JWTTest.java +++ b/lib/src/test/java/com/auth0/jwt/JWTTest.java @@ -4,7 +4,6 @@ import com.auth0.jwt.interfaces.DecodedJWT; import org.hamcrest.collection.IsCollectionWithSize; import org.hamcrest.core.IsCollectionContaining; -import org.junit.Ignore; import org.junit.Rule; import org.junit.Test; import org.junit.rules.ExpectedException; diff --git a/lib/src/test/java/com/auth0/jwt/algorithms/ECDSAAlgorithmTest.java b/lib/src/test/java/com/auth0/jwt/algorithms/ECDSAAlgorithmTest.java index 30a3efaf..8dd00ca3 100644 --- a/lib/src/test/java/com/auth0/jwt/algorithms/ECDSAAlgorithmTest.java +++ b/lib/src/test/java/com/auth0/jwt/algorithms/ECDSAAlgorithmTest.java @@ -6,7 +6,6 @@ import com.auth0.jwt.interfaces.ECDSAKeyProvider; import org.hamcrest.Matchers; import org.hamcrest.collection.IsIn; -import org.junit.Ignore; import org.junit.Rule; import org.junit.Test; import org.junit.rules.ExpectedException; diff --git a/lib/src/test/java/com/auth0/jwt/algorithms/ECDSABouncyCastleProviderTests.java b/lib/src/test/java/com/auth0/jwt/algorithms/ECDSABouncyCastleProviderTests.java index 6b0266a4..675baeff 100644 --- a/lib/src/test/java/com/auth0/jwt/algorithms/ECDSABouncyCastleProviderTests.java +++ b/lib/src/test/java/com/auth0/jwt/algorithms/ECDSABouncyCastleProviderTests.java @@ -5,7 +5,10 @@ import com.auth0.jwt.exceptions.SignatureVerificationException; import com.auth0.jwt.interfaces.ECDSAKeyProvider; import org.bouncycastle.jce.provider.BouncyCastleProvider; -import org.junit.*; +import org.junit.AfterClass; +import org.junit.BeforeClass; +import org.junit.Rule; +import org.junit.Test; import org.junit.rules.ExpectedException; import java.nio.charset.StandardCharsets;