Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back the integratedWindowsLogin option? #852

Closed
nicosabena opened this issue Feb 2, 2017 · 0 comments
Closed

Bring back the integratedWindowsLogin option? #852

nicosabena opened this issue Feb 2, 2017 · 0 comments
Labels
enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature
Milestone

Comments

@nicosabena
Copy link
Contributor

Lock v9 had an integratedWindowsLogin option which defaulted to true that allowed skipping the blue "Windows Authentication" button for Kerberos signin when set to false (code here). This option is no longer present in v10 (although it was documented).

Lock currently shows that button based on the IP address (AFAIK), but some users might be in the network and using a Windows machine (or just not connected to AD), so the "Windows Authentication" button doesn't always make sense.

Not sure if the showing/hiding could be automated somehow, but at least giving the flexibility of setting the integratedWindowsLogin option to false seems like a handy alternative.

Note that rememberLastLogin: false can be used now to skip the Windows login button, but this may stop working if this PR gets merged.

@hzalaz hzalaz added this to the v10-Next milestone Feb 22, 2017
@hzalaz hzalaz modified the milestones: v10-Next, v10.12.0 Mar 2, 2017
@hzalaz hzalaz added the enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature label Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature
Projects
None yet
Development

No branches or pull requests

2 participants