-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinning react version 15.6.2 #1142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Are there plans to release a react 16 compatible package? |
What are the drawbacks of using the resolutions field? |
Probably best covered by the original RFC & its conversation. There's no support for it in npm (granted yarn is more widely in use now, and personally I prefer it), but this is forcing end users to use yarn exclusively for now; that's not always desirable/possible. |
I understand what you're saying and I can see your point clearly. We understand the trade offs (no npm support or people might not know about yarn resolutions), but we're in a tough spot to solve the issue. We should move to peer dependencies, but we can't do that without releasing a new major version and major reviews of our docs, samples and quickstarts. We just can't dedicate the time to doing that right now. Rest assured we will fix this situation, but, considering we have a clear and simple workaround (resolutions or cdn), we are focusing on more important and valuable things right now. The benefit of waiting a bit more is that more and more projects will upgrade to react@16, which will make our job a bit easier 🎉 . Once we upgrade to react@16, we will suggest people still using react@15 as well, so they can have more time to upgrade. Again, I'm sorry this is not the answer most of react@16 users want to read, but it is the place that we encounter ourselves right now. |
Happy so long as you guys have it on a roadmap somewhere. 🤤 |
We'll absolutely fix this in the next major! |
We can't reliably make this library available in both react@15 and react@16 without changing react and react-dom to peerDependencies. Since this would break everyone moving forward, we decided to pin version ^15.6.2 in this library.