Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistent screen title #1288

Merged
merged 2 commits into from
Mar 8, 2018
Merged

Fix inconsistent screen title #1288

merged 2 commits into from
Mar 8, 2018

Conversation

luisrudge
Copy link
Contributor

fix #1286

@luisrudge luisrudge added this to the v11.4.0 milestone Mar 8, 2018
joshcanhelp
joshcanhelp approved these changes Mar 8, 2018
View reviewed changes
Copy link
Contributor

@joshcanhelp joshcanhelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches our thorough discussion in Slack ... LGTM

@lbalmaceda
Copy link
Contributor

👍

@luisrudge luisrudge merged commit 442a2f3 into master Mar 8, 2018
@luisrudge luisrudge deleted the fix-inconsistent-screen-title branch March 8, 2018 19:52
@luisrudge luisrudge mentioned this pull request Mar 19, 2018
Closed
This was referenced May 25, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshcanhelp joshcanhelp joshcanhelp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v11.4.0
Development

Successfully merging this pull request may close these issues.

Screen title behavior is misleading
3 participants
@luisrudge @lbalmaceda @joshcanhelp