Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ariaLabel option for custom fields #1492

Merged
merged 4 commits into from
Oct 3, 2018
Merged

Add ariaLabel option for custom fields #1492

merged 4 commits into from
Oct 3, 2018

Conversation

Splact
Copy link
Contributor

@Splact Splact commented Oct 1, 2018

  • Let the user define labels for additional signup fields
  • Set Alt attribute on icon
  • When we use name as aria-label now we give higher priority to the new label property

luisrudge
luisrudge suggested changes Oct 2, 2018
View reviewed changes
Copy link
Contributor

@luisrudge luisrudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Thanks for the PR. 🎉

  • Please update the test snapshots
  • I think it's best to use the ariaLabel property name. This way, anyone implementing this won't think that the label property will actually be a label in the screen
  • Please add a readme example of the new proprety

@Splact
Copy link
Contributor Author

Splact commented Oct 3, 2018

All done :)!

@luisrudge
Copy link
Contributor

Thanks for the PR! 🎉

@luisrudge luisrudge merged commit ab7c94f into auth0:master Oct 3, 2018
@luisrudge luisrudge changed the title Improve labelling Add ariaLabel option for custom fields Oct 3, 2018
@luisrudge luisrudge added this to the v11.12.0 milestone Oct 23, 2018
@MaxMood96 MaxMood96 mentioned this pull request Jan 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisrudge luisrudge luisrudge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v11.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Splact @luisrudge