Fix padding in all screens #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocojoe
approved these changes
Nov 13, 2018
|
in hindsight, the copy/paste was the wrong approach anyway 😬 The padding is now being added to the div that wraps all screens, so we're good now. |
luisrudge
added a commit
that referenced
this pull request
Nov 13, 2018
This reverts commit f279f28.
luisrudge
added a commit
that referenced
this pull request
Nov 13, 2018
This reverts commit f279f28.
luisrudge
added a commit
that referenced
this pull request
Nov 13, 2018
Merged
luisrudge
added a commit
that referenced
this pull request
Nov 15, 2018
### Changes This PR fixes - Inconsistent padding across screens after #1547  - IE glitches after we added flexbox in #1539 (the actual issues were: https://github.com/philipwalton/flexbugs#flexbug-3, https://github.com/philipwalton/flexbugs#flexbug-4 and https://github.com/philipwalton/flexbugs#flexbug-6)  # GIFs (it's not JIF) ## IE 10  ## IE 11  ## Edge 17  ## Firefox  ## Safari  ## Chrome  ## Pixel 2  ## Galaxy S9  ## iPhone 7  ## iPhone X 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When we did #1539, I had to create another div to wrap the internal content. It was copy/paster in every "screen" component, but I forgot in some of them. Instead of continue the copy/paste, I added the padding to the screen's wrapper component. This will have the same effect and it works with all screens (current and new) OOTB.
References
#1539
Testing