Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lock is undefined error in non-redirect scenarios #1557

Merged
merged 2 commits into from
Nov 23, 2018

Conversation

luisrudge
Copy link
Contributor

@luisrudge luisrudge commented Nov 23, 2018

fix #1556

Changes

Passing the lock instance as props so the confirmation pane (only shown when redirect:false) doesn't throw an error.

References

#1556

@luisrudge luisrudge changed the title Fix lock is undefined Fix lock is undefined error in non-redirect scenarios Nov 23, 2018
@luisrudge luisrudge added this to the v11.12.1 milestone Nov 23, 2018
@cocojoe
Copy link
Member

cocojoe commented Nov 23, 2018

How is this tested?

@luisrudge luisrudge merged commit f317c50 into master Nov 23, 2018
@luisrudge luisrudge deleted the fix/lock-undefined branch November 23, 2018 18:41
jfromaniello pushed a commit to jfromaniello/auth0-lock that referenced this pull request Jun 26, 2020
fix auth0#1556

Passing the lock instance as props so the confirmation pane (only shown when redirect:false) doesn't throw an error.

auth0#1556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lock v11.12.0 throws an error on login
3 participants