Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Lock event 'sso login' #1742

Merged
merged 2 commits into from
Oct 28, 2019
Merged

Add a Lock event 'sso login' #1742

merged 2 commits into from
Oct 28, 2019

Conversation

countergram
Copy link

@countergram countergram commented Oct 23, 2019

Changes

This extends the existing event emitter pattern with a new event, called sso login (casing & spacing follows the existing federated login event name for social).

Our current use case for this is to make some adjustments (which have to be pre-login) based on our enterprise clients with their own IdPs logging in by doing our own lookup of the client's configuration.

References

This will help with a support ticket on my company's account: https://support.auth0.com/tickets/00439926

Testing

The existing npm run test:cli passes. I do not see any unit test cases currently existing for event emitters such as federated login so it doesn't appear to be a pattern now. I don't have access to Saucelabs to run the default npm test.

Checklist

@countergram countergram requested a review from a team October 23, 2019 16:05
@joshcanhelp
Copy link
Contributor

@countergram - Appreciate the contribution here! From a code standpoint, it looks fine but I want to pass it by the primary maintainers here to make sure an additional event makes sense.

Stay tuned!

@joshcanhelp joshcanhelp requested review from luisrudge and stevehobbsdev and removed request for a team October 24, 2019 19:32
@luisrudge luisrudge merged commit 6b07de1 into auth0:master Oct 28, 2019
@stevehobbsdev stevehobbsdev added this to the v11.18.1 milestone Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants