Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-1374] Email input now uses type="email" #1802

Merged
merged 3 commits into from
Feb 14, 2020

Conversation

stevehobbsdev
Copy link
Contributor

@stevehobbsdev stevehobbsdev commented Feb 14, 2020

Changes

This PR changes the email input so that it uses the type="email" attribute, which fixes issues on some mobile devices around autocorrecting email addresses.

References

Fixes #1798

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@stevehobbsdev stevehobbsdev added this to the vNext milestone Feb 14, 2020
@stevehobbsdev stevehobbsdev self-assigned this Feb 14, 2020
@stevehobbsdev stevehobbsdev marked this pull request as ready for review February 14, 2020 11:41
@stevehobbsdev stevehobbsdev requested a review from a team February 14, 2020 11:41
@stevehobbsdev stevehobbsdev merged commit 0086fe7 into master Feb 14, 2020
@stevehobbsdev stevehobbsdev deleted the fix/email-text-field branch February 14, 2020 16:19
jfromaniello pushed a commit to jfromaniello/auth0-lock that referenced this pull request Mar 5, 2020
* Adjusted email input to use the type='email' attribute

* Added render test for email_input
davidpatrick pushed a commit to davidpatrick/lock that referenced this pull request Jun 12, 2020
* Adjusted email input to use the type='email' attribute

* Added render test for email_input
jfromaniello pushed a commit to jfromaniello/auth0-lock that referenced this pull request Jul 23, 2020
* Adjusted email input to use the type='email' attribute

* Added render test for email_input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Email input is rendering with type="text"
2 participants