[SDK-1413] Re-added scrollbars and fixed password strength popup clip issue #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjmcgrath
approved these changes
Apr 1, 2020
|
Hi team, The strength popup clip issue still exists in some cases. Steps to reproduce:
|
davidpatrick
pushed a commit
to davidpatrick/lock
that referenced
this pull request
Jun 12, 2020
… issue (auth0#1839) * Moved header into wrapper, fixed styles, re-added scrollbars * Automatically calculated margin for inner content to clear header * Added render tests for Chrome box
jfromaniello
pushed a commit
to jfromaniello/auth0-lock
that referenced
this pull request
Jul 23, 2020
… issue (auth0#1839) * Moved header into wrapper, fixed styles, re-added scrollbars * Automatically calculated margin for inner content to clear header * Added render tests for Chrome box
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
References
Fixes #1832
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist