[ESD-6221] Remove CSS variable from header height calculation #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehobbsdev
changed the title
adamjmcgrath
approved these changes
May 18, 2020
davidpatrick
pushed a commit
to davidpatrick/lock
that referenced
this pull request
Jun 12, 2020
…1867) * Fixed header height when tabs change * Removed unused import for store
jfromaniello
pushed a commit
to jfromaniello/auth0-lock
that referenced
this pull request
Jul 23, 2020
…1867) * Fixed header height when tabs change * Removed unused import for store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change effectively reverts #1859 and reimplements the header height calculation in a way that doesn't use a CSS variable (this was breaking in IE11). All of this is designed to handle the case where the title is too large to be contained on one line.
To do this, this PR implements the ability for Lock to handle its own emitted events, and handles the
signin readyandsignup readyevents to responds to tab changes and recalculate the header size.IE11 render
References
This was raised via an internal service desk ticket, from customers who were seeing header size issues in IE11 thanks to the lack of CSS variable support.
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist