Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-2295] Add forceAutoHeight property to UI config #2050

Merged
merged 2 commits into from
Oct 7, 2021

Conversation

stevehobbsdev
Copy link
Contributor

@stevehobbsdev stevehobbsdev commented Oct 7, 2021

Changes

This PR adds a new UI property forceAutoHeight that enables the auto-height class and height: auto!important style on the wrapper div. This helps scenarios that don't want to use the default calculated height.

new Auth0Lock(clientId, domain, {
  forceAutoHeight: true
});

References

Fixes #1963

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@stevehobbsdev stevehobbsdev requested a review from a team as a code owner October 7, 2021 10:32
@stevehobbsdev stevehobbsdev added the review:small Small review label Oct 7, 2021
@stevehobbsdev stevehobbsdev changed the title Revert the revert of the forceAutoHeight property [SDK-2295] Add forceAutoHeight property to UI config Oct 7, 2021
@stevehobbsdev stevehobbsdev merged commit c4ded65 into master Oct 7, 2021
@stevehobbsdev stevehobbsdev deleted the fix/auto-height branch October 7, 2021 13:35
@stevehobbsdev stevehobbsdev mentioned this pull request Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration option to disable full screen height in mobile
2 participants