Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESD-22866] Disable spellcheck and autocorrect on all sensitive input fields #2178

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

ewanharris
Copy link
Contributor

Changes

Disables autocorrect and spellcheck for all sensitive inputs.

spellcheck has recently been discovered to potentially disclose information to browser vendors that provide this feature. So disabling it helps to prevent this.

autocorrect is a safari only feature that will autocorrect what it believes to be misspelled words, so this is disabled for user experience.

Both of these were already set for UsernameInput, so this is just bring other fields in line with that. Albeit spellcheck was not correctly set.

❓ I'm not sure if it would make sense to also enable this for VcodeInput and PhoneNumberInput too ❓

Testing

Open the playground in the browser, make typos in the email field and it should no longer give you a red squiggle

Checklist

@ewanharris ewanharris requested a review from a team as a code owner September 23, 2022 17:47
These were already disabled for the username field spellcheck has recently been discovered to
potentially disclose information to browser vendors that provide this feature. So disabling it
helps to prevent this.

autocorrect is a safari only feature that will autocorrect what it believes to be misspelled words,
so this is disabled for user experience
@stevehobbsdev
Copy link
Contributor

❓ I'm not sure if it would make sense to also enable this for VcodeInput and PhoneNumberInput too ❓

@ewanharris Let's just do it on those additional fields as well 👍🏻

@ewanharris
Copy link
Contributor Author

@stevehobbsdev, added the properties to those fields

@stevehobbsdev stevehobbsdev merged commit 213bcb5 into master Sep 29, 2022
@stevehobbsdev stevehobbsdev deleted the ESD-22866 branch September 29, 2022 09:16
@ewanharris ewanharris mentioned this pull request Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants