Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when component is undefined #2271

Merged
merged 3 commits into from
Feb 10, 2023

Conversation

codetheweb
Copy link
Contributor

Changes

A bug seems to have been recently introduced in v12:

Screenshot 2023-02-08 at 11 29 11 AM

This happens because

this.modals[containerId].component.hide();

assumes that if this.modals[containerId] is defined, this.modals[containerId].component is also defined. But this isn't always the case:

this.modals[containerId] = { root };

Checklist

@codetheweb codetheweb requested a review from a team as a code owner February 8, 2023 19:35
Copy link
Contributor

@stevehobbsdev stevehobbsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@stevehobbsdev
Copy link
Contributor

@codetheweb I'm unable to merge changes from master into this, if you could please merge it when you get a chance.

@codetheweb
Copy link
Contributor Author

Updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants