Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single AD connection without domain shows undefined in message #642

Merged
merged 2 commits into from
Oct 17, 2016
Merged

Single AD connection without domain shows undefined in message #642

merged 2 commits into from
Oct 17, 2016

Conversation

glena
Copy link
Contributor

@glena glena commented Oct 13, 2016

Closes #627

@glena glena added this to the v10.5.0 milestone Oct 13, 2016
hzalaz
hzalaz suggested changes Oct 17, 2016
View reviewed changes
src/connection/enterprise/hrd_screen.jsx

var headerText;

if (domain) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change it to

if (domain != null) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@hzalaz hzalaz merged commit 4095bca into auth0:master Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzalaz hzalaz hzalaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v10.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@glena @hzalaz