Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No method to update/patch resource servers #156

Closed
6 tasks done
philomory opened this issue Jan 28, 2019 · 2 comments
Closed
6 tasks done

No method to update/patch resource servers #156

philomory opened this issue Jan 28, 2019 · 2 comments
Labels
enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature
Milestone

Comments

@philomory
Copy link
Contributor

philomory commented Jan 28, 2019

Description

There's no method in the gem to update a resource server (e.g. to call PATCH /api/v2/resource-servers/[id]); corresponding methods exist for other endpoints such as Clients.

I have a WIP PR for this.

Prerequisites

Environment

Please provide the following:

  • Ruby Auth0 version: 4.6.0
  • Ruby version: 2.4.4p296
  • Rails version (if applicable): N/A
  • Browser version (if applicable): N/A
  • Additional gems that might be affecting your instance: N/A

Reproduction

irb(main):001:0> connection = Auth0::Client.new(...)
irb(main):002:0> connection.patch_resource_server(...)
NoMethodError: undefined method `patch_resource_servers' for #<Auth0::Client:0x00000000073974a0>
@joshcanhelp
Copy link
Contributor

@philomory - Appreciate the help with these! You are approved to proceed 😃

@joshcanhelp joshcanhelp added this to the v4.7.0 milestone Jan 29, 2019
@joshcanhelp joshcanhelp added enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature and removed CH: Added labels Jan 29, 2019
@joshcanhelp
Copy link
Contributor

Merged!

@joshcanhelp joshcanhelp added enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature and removed enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature
Projects
None yet
Development

No branches or pull requests

2 participants