Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement API v2 #38

Closed
ignaciojonas opened this issue Nov 30, 2015 · 3 comments
Closed

Implement API v2 #38

ignaciojonas opened this issue Nov 30, 2015 · 3 comments

Comments

@ignaciojonas
Copy link
Contributor

We took a look to the API V2 and found some endpoints that are not implemented.

Our plan is to implement those endpoints and review the already implemented ones.

Endpoints to be implemented

  • Device Credentials (3 endpoints)
  • Rules (5 endpoints)
  • Email (4 endpoints)
  • Tickets (2 endpoints)

Methods to be implemented

  • Jobs
    • create_job

      This method needs to be implemented using multipart upload, HTTParty doesn't support it. We think that we can switch to use HTTMultiParty which supports multipart upload.

We also found that the API code is not documented and the code style can be improved. We would suggest to:

Regarding the integration tests, we would like to add more tests for all the endpoints in the API.
Currently just the clients, connections and users are tested. We are planning to create integration tests for all endpoints, against the real Auth-0 API in order to have a better integration scenario.

We'll start working on fixing the code style in order to clean the code base first.

We would love to hear your feedback on any of these topics.

@npetkov
Copy link

npetkov commented Jan 18, 2016

Hi, our team just finished integrating Auth0 in a Rails application, but we're still missing some features in the ruby bridge, like ticket and job creation. There has been quite some movement in the v2 branch recently, so we're wondering if you're planning a release soon?

@joshRpowell
Copy link

+1

@dentarg
Copy link
Contributor

dentarg commented Apr 1, 2016

I just want to note that https://github.com/jwagener-soundcloud/httmultiparty now seems to be unmaintained, might become a problem in the long-term.

@ntotten ntotten closed this as completed Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants