Add pagination and tests for Rules endpoint #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machuga
reviewed
Jul 7, 2018
lib/auth0/api/v2/rules.rb
Outdated
| stage: stage | ||
| stage: stage, | ||
| page: !page.nil? ? page.to_i : nil, | ||
| per_page: !page.nil? && !per_page.nil? ? per_page.to_i : nil |
There was a problem hiding this comment.
Going to give this the same feedback as the other one where this logic is confusing to read through. I'm noticing the other params aren't being cast in any way. Can you elaborate more on why we are casting these vars?
There was a problem hiding this comment.
Since I'm adding new params here, I was only casting the additions, not the others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pageandper_pageparameters toAuth0::Api::V2::Rules::rulesendpointsleepdirectives from the rules integration tests