Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up auth endpoint tests #120

Merged
merged 1 commit into from
Jul 20, 2018
Merged

Clean up auth endpoint tests #120

merged 1 commit into from
Jul 20, 2018

Conversation

joshcanhelp
Copy link
Contributor

  • Change URI.escape -> CGI.escape, as recommended by Rubocop
  • Formatting and cleanup on tests for methods that are not being replaced/deprecated

@joshcanhelp joshcanhelp added this to the v4-Next milestone Jul 17, 2018
@cocojoe
Copy link
Member

cocojoe commented Jul 20, 2018

@joshcanhelp do these tests still un locally ok?

@joshcanhelp
Copy link
Contributor Author

@cocojoe - Yes, mostly whitespace changes

cocojoe
cocojoe approved these changes Jul 20, 2018
View reviewed changes
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then

@joshcanhelp joshcanhelp force-pushed the fix-auth-endpoint-tests branch from cab149e to 31b8895 Compare July 20, 2018 14:19
@joshcanhelp joshcanhelp merged commit 5bf57ef into master Jul 20, 2018
@joshcanhelp joshcanhelp deleted the fix-auth-endpoint-tests branch July 20, 2018 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocojoe cocojoe cocojoe approved these changes

Assignees
No one assigned
Labels
CH: Fixed
Projects
None yet
Milestone
v4.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joshcanhelp @cocojoe