Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the client work for API v1 #13

Merged
merged 1 commit into from
Mar 12, 2015
Merged

Conversation

dentarg
Copy link
Contributor

@dentarg dentarg commented Mar 11, 2015

We should probably have some integration tests, right? :)

@offtop
Copy link
Contributor

offtop commented Mar 12, 2015

Critical update, please merge it.

jfromaniello added a commit that referenced this pull request Mar 12, 2015
Make the client work for API v1
@jfromaniello jfromaniello merged commit 3d23858 into auth0:master Mar 12, 2015
@jfromaniello
Copy link
Member

Thanks, released as 3.1.2.

Regarding integration tests.. what can we do?

@dentarg
Copy link
Contributor Author

dentarg commented Mar 12, 2015

Dedicate an auth0 account for tests, keys can be encrypted in .travis.yml, write tests that actually do stuff with the API. What do you think?

On 12 mar 2015, at 14:21, José F. Romaniello [email protected] wrote:

Thanks, released as 3.1.2.

Regarding integration tests.. what can we do?


Reply to this email directly or view it on GitHub.

@dentarg
Copy link
Contributor Author

dentarg commented Mar 12, 2015

Created #15

@dentarg
Copy link
Contributor Author

dentarg commented Mar 22, 2015

Thanks, released as 3.1.2.

@jfromaniello did you forget to push?

VERSION = "3.1.1"
still says 3.1.1

master: https://github.com/auth0/ruby-auth0/blob/master/lib/auth0/version.rb#L3

@dentarg
Copy link
Contributor Author

dentarg commented Mar 24, 2015

ping @jfromaniello

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants