-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VCR to and improve all integration tests #132
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
--- | ||
BUNDLE_JOBS: '4' | ||
BUNDLE_BIN: bin | ||
BUNDLE_JOBS: "3" | ||
BUNDLE_BIN: "bin" | ||
BUNDLE_RETRY: "3" |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,4 +12,5 @@ end | |
|
||
group :test do | ||
gem 'webmock', require: false | ||
gem 'vcr', require: false | ||
end |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -101,7 +101,7 @@ def delete_user(user_id) | |
# @return [json] Returns the updated user. | ||
def patch_user(user_id, body) | ||
raise Auth0::MissingUserId, 'Must supply a valid user_id' if user_id.to_s.empty? | ||
raise Auth0::InvalidParameter, 'Must supply a valid body' if body.to_s.empty? | ||
raise Auth0::InvalidParameter, 'Must supply a valid body' if body.to_s.empty? || body.empty? | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Did not catch an empty hash |
||
path = "#{users_path}/#{user_id}" | ||
patch(path, body) | ||
end | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was not actually checking for what it was trying to check for