Improve the test suite #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
commented
Oct 26, 2018
| @@ -14,25 +29,30 @@ | |||
| config.filter_sensitive_data('API_TOKEN') { ENV['MASTER_JWT'] } | |||
| end | |||
|
|
|||
| mode = ENV['MODE'] || 'unit' | |||
There was a problem hiding this comment.
Removed the test mode now that we're using VCR
joshcanhelp
commented
Oct 26, 2018
| def entity_suffix | ||
| 'rubytest' | ||
| end | ||
|
|
||
| puts "Entity suffix is #{entity_suffix}" |
There was a problem hiding this comment.
Moving test mode-specific code
lbalmaceda
reviewed
Oct 26, 2018
Gemfile
Outdated
| @@ -13,4 +13,5 @@ end | |||
| group :test do | |||
| gem 'webmock', require: false | |||
| gem 'vcr', require: false | |||
| gem 'codecov', :require => false | |||
spec/spec_helper.rb
Outdated
| @@ -6,6 +20,7 @@ | |||
|
|
|||
| require 'vcr' | |||
| VCR.configure do |config| | |||
| # Uncomment the line below to record new cassettes | |||
There was a problem hiding this comment.
what does that mean? should it be clarified?
| @@ -14,25 +29,30 @@ | |||
| config.filter_sensitive_data('API_TOKEN') { ENV['MASTER_JWT'] } | |||
| end | |||
|
|
|||
| mode = ENV['MODE'] || 'unit' | |||
| Dir['./lib/**/*.rb'].each { |f| require f } | ||
| Dir['./spec/support/**/*.rb'].each { |f| require f } | ||
| Dir['./spec/support/*.rb'].each { |f| require f } | ||
|
|
||
| require 'rspec' |
There was a problem hiding this comment.
cosmetic but, shouldn't this be on the top of the file instead of flying here?
There was a problem hiding this comment.
Actually no ... config.include Credentials needs to happen after the file requires
lbalmaceda
approved these changes
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fullENV vartestRake task