Add Client ID to send_verification_email #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
changed the title
luisrudge
approved these changes
Mar 18, 2019
| def fields_for_export(fields) | ||
| return nil if fields.nil? || fields.empty? | ||
| return nil if fields.to_s.empty? |
There was a problem hiding this comment.
Simplification ... I think it was suggested by the formatting tool rubocop
| @@ -21,6 +21,7 @@ module HTTPProxy | |||
| elsif method == :delete | |||
| call(:delete, url(safe_path), timeout, add_headers({params: body})) | |||
| elsif method == :post_file | |||
| body.merge!(multipart: true) | |||
There was a problem hiding this comment.
The import method was not working as it was written, which I found out when the tests were finally running (instead of being skipped).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Auth0::Api::V2::Jobs.send_verification_emailReferences
Fixes #92
Testing
Failing tests for new feature
Checklist