Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add failed job error details endpoint #176

Merged
merged 2 commits into from
Jul 10, 2019
Merged

Add failed job error details endpoint #176

merged 2 commits into from
Jul 10, 2019

Conversation

makoto-matsumoto
Copy link
Contributor

@makoto-matsumoto makoto-matsumoto commented Jun 29, 2019 •
edited
Loading

Changes

Add endpoint for failed job error details.

References

https://auth0.com/docs/api/management/v2#!/Jobs/get_errors

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of Ruby

Checklist

@makoto-matsumoto makoto-matsumoto requested a review from a team June 29, 2019 12:41
@joshcanhelp joshcanhelp added this to the v4.8.0 milestone Jul 1, 2019
@joshcanhelp
Copy link
Contributor

@makoto-matsumoto - Thanks for this as well! We'll get CI running on PRs and get this merged in ASAP, then released this week.

@joshcanhelp
Copy link
Contributor

Closing and re-opening to trigger CI

@joshcanhelp joshcanhelp closed this Jul 1, 2019
@joshcanhelp joshcanhelp mentioned this pull request Jul 1, 2019
Merged
4 tasks
@joshcanhelp joshcanhelp reopened this Jul 1, 2019
@joshcanhelp joshcanhelp self-assigned this Jul 1, 2019
@joshcanhelp joshcanhelp requested review from joshcanhelp and removed request for a team July 1, 2019 16:46
@joshcanhelp
Copy link
Contributor

@makoto-matsumoto - OK, this one is ready to go! Just rebase master and push and tests should pass 👍

@makoto-matsumoto makoto-matsumoto force-pushed the add_failed_job_error_details branch from 1aebdae to aafebe3 Compare July 3, 2019 04:03
@makoto-matsumoto
Copy link
Contributor Author

@joshcanhelp

Please confirm this too!

@joshcanhelp
Copy link
Contributor

@makoto-matsumoto - Just FYI, the tests are failing because we don't have environmental variables. I'm looking into that this week to see what we can do. I'll make sure this gets merged before the next release.

Same for #177

@joshcanhelp joshcanhelp merged commit dd827d4 into auth0:master Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshcanhelp joshcanhelp joshcanhelp approved these changes

Assignees

@joshcanhelp joshcanhelp

Labels
CH: Added
Projects
None yet
Milestone
v4.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@makoto-matsumoto @joshcanhelp