Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-1542] Add client secret to Passwordless flow since it is now required #217

Merged

Conversation

stevehobbsdev
Copy link
Contributor

Changes

Following https://community.auth0.com/t/passwordless-connection-not-working-for-tenants-created-after-jan-2-2020/36415/5 , it is now required to send client_secret through the passwordless endpoints.

This PR simply adds client_secret to the POST requests, following this spec.

PR tested on my app. Fails before (error Auth0::AccessDenied: {"error":"unauthorized_client","error_description":"Client authentication is required"}), pass after.

References

This PR replaces #213

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of Ruby

Checklist

@stevehobbsdev stevehobbsdev requested a review from a team May 1, 2020 10:43
@stevehobbsdev stevehobbsdev changed the title Add client secret to Passwordless flow since it is now required [SDK-1542] Add client secret to Passwordless flow since it is now required May 1, 2020
@lbalmaceda lbalmaceda merged commit 8054ff6 into master May 4, 2020
@lbalmaceda lbalmaceda deleted the QontrolLab-add_client_secret_to_passwordless_login branch May 4, 2020 17:15
@Widcket Widcket added this to the v4.11.0 milestone May 6, 2020
@Widcket Widcket mentioned this pull request May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants